From 09cd1f575476a48b262e4e45997bb56753f9d4f5 Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Mon, 27 Jul 2009 07:25:57 -0700 Subject: Fix STB_GNU_UNIQUE handling for > 30 unique symbols. There were several issues when the initial 31 entries hashtab filled up. size * 3 <= tab->n_elements is always false, table can't have more elements than its size. I assume from libiberty/hashtab.c this meant to be check for 3/4 full. Even after fixing that, _dl_higher_prime_number (31) apparently returns 31, only _dl_higher_prime_number (32) returns 61. And, size variable wasn't updated during reallocation, which means during reallocation the insertion of the new entry was done into a wrong spot. All this lead to a hang in ld.so, because a search with n_elements 31 size 31 wouldn't ever terminate. --- ChangeLog | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'ChangeLog') diff --git a/ChangeLog b/ChangeLog index 801ec189d0..8cc2e675c9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2009-07-27 Jakub Jelinek + + * elf/dl-lookup.c (do_lookup_x): Fix check for table more than + 3/4 full. Pass size + 1 rather than size to _dl_higher_prime_number. + Update size when reallocating. + 2009-07-26 Ulrich Drepper * sysdeps/x86_64/tst-xmmymm.sh: New file. Check whether any of the -- cgit v1.2.3