From 71effcea34f7b23e54bc15b42c7a837de91cdfc0 Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Fri, 18 Jan 2019 22:38:32 +0100 Subject: malloc: Revert fastbins to old-style atomics Commit 6923f6db1e688dedcf3a6556da76e0bf24a41872 ("malloc: Use current (C11-style) atomics for fastbin access") caused a substantial performance regression on POWER and Aarch64, and the old atomics, while hard to prove correct, seem to work in practice. --- ChangeLog | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'ChangeLog') diff --git a/ChangeLog b/ChangeLog index 59d8b83289..0e7429afb5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,17 @@ +2019-01-18 Florian Weimer + + malloc: Revert commit 6923f6db1e688dedcf3a6556da76e0bf24a41872 + ("malloc: Use current (C11-style) atomics for fastbin access"). + This commit introduces a substantial performance regression on + POWER and Aarch64. + * malloc/malloc.c (fastbin_push_entry, fastbin_pop_entry): Remove. + (REMOVE_FB): Define. + (_int_malloc): Use it and reindent. + (_int_free): Use CAS loop with + catomic_compare_and_exchange_val_rel. + (malloc_consolidate): Use atomic_exchange_acq. + + 2019-01-18 H.J. Lu * signal/Makefile (LDFLAGS-tst-minsigstksz-1): New. Set to -- cgit v1.2.3