From 4c3df0eba5e8fe98f0de917ade9b2ebba6951c5f Mon Sep 17 00:00:00 2001 From: Adhemerval Zanella Date: Tue, 15 Jun 2021 21:00:50 -0300 Subject: linux: Only use 64-bit syscall if required for select For !__ASSUME_TIME64_SYSCALLS there is no need to issue a 64-bit syscall if the provided timeout fits in a 32-bit one. The 64-bit usage should be rare since the timeout is a relative one. This also avoids the need to use supports_time64() (which breaks the usage case of live migration like CRIU or similar). It also fixes an issue on 32-bit select call for !__ASSUME_PSELECT (microblase with older kernels only) where the expected timeout is a 'struct timeval' instead of 'struct timespec'. Checked on i686-linux-gnu on a 4.15 kernel and on a 5.11 kernel (with and without --enable-kernel=5.1) and on x86_64-linux-gnu. Reviewed-by: Lukasz Majewski --- include/sys/select.h | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'include/sys/select.h') diff --git a/include/sys/select.h b/include/sys/select.h index ec073deeba..a8961afbed 100644 --- a/include/sys/select.h +++ b/include/sys/select.h @@ -21,6 +21,11 @@ extern int __pselect32 (int __nfds, fd_set *__readfds, const struct __timespec64 *__timeout, const __sigset_t *__sigmask) attribute_hidden; +extern int __select32 (int __nfds, fd_set *__readfds, + fd_set *__writefds, fd_set *__exceptfds, + const struct __timespec64 *ts64, + struct __timeval64 *timeout) + attribute_hidden; extern int __select64 (int __nfds, fd_set *__readfds, fd_set *__writefds, fd_set *__exceptfds, -- cgit v1.2.3