From 2d7acfac3ebf266dcbc82d0d6cc576f626953a03 Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Tue, 14 Aug 2018 10:51:07 +0200 Subject: nscd: Deallocate existing user names in file parser This avoids a theoretical memory leak (theoretical because it depends on multiple server-user/stat-user directives in the configuration file). --- nscd/nscd_conf.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'nscd') diff --git a/nscd/nscd_conf.c b/nscd/nscd_conf.c index 265a02434d..7293b795b6 100644 --- a/nscd/nscd_conf.c +++ b/nscd/nscd_conf.c @@ -190,7 +190,10 @@ nscd_parse_file (const char *fname, struct database_dyn dbs[lastdb]) if (!arg1) error (0, 0, _("Must specify user name for server-user option")); else - server_user = xstrdup (arg1); + { + free ((char *) server_user); + server_user = xstrdup (arg1); + } } else if (strcmp (entry, "stat-user") == 0) { @@ -198,6 +201,7 @@ nscd_parse_file (const char *fname, struct database_dyn dbs[lastdb]) error (0, 0, _("Must specify user name for stat-user option")); else { + free ((char *) stat_user); stat_user = xstrdup (arg1); struct passwd *pw = getpwnam (stat_user); -- cgit v1.2.3