From 67e3b0c63c35769c1ba28fa2a32446332bb4fcef Mon Sep 17 00:00:00 2001 From: Siddhesh Poyarekar Date: Wed, 6 Apr 2022 20:53:24 +0530 Subject: tests/string: Drop simple/stupid/builtin tests In most cases the simple/stupid/builtin functions were in there to benchmark optimized implementations against. Only in some cases the functions are used to check expected results. Remove these tests from IMPL() and only keep them in wherever they're used for a specific purpose, e.g. to generate expected results. This improves timing of `make subdirs=string` by over a minute and a half (over 15%) on a Whiskey Lake laptop. Signed-off-by: Siddhesh Poyarekar Reviewed-by: Noah Goldstein --- string/test-strcasecmp.c | 25 ++----------------------- 1 file changed, 2 insertions(+), 23 deletions(-) (limited to 'string/test-strcasecmp.c') diff --git a/string/test-strcasecmp.c b/string/test-strcasecmp.c index 438a9713ac..fe48d1197f 100644 --- a/string/test-strcasecmp.c +++ b/string/test-strcasecmp.c @@ -27,14 +27,11 @@ #include "test-string.h" typedef int (*proto_t) (const char *, const char *); -static int simple_strcasecmp (const char *, const char *); -static int stupid_strcasecmp (const char *, const char *); -IMPL (stupid_strcasecmp, 0) -IMPL (simple_strcasecmp, 0) IMPL (strcasecmp, 1) -static int +/* Naive implementation to verify results. */ +int simple_strcasecmp (const char *s1, const char *s2) { int ret; @@ -46,24 +43,6 @@ simple_strcasecmp (const char *s1, const char *s2) return ret; } -static int -stupid_strcasecmp (const char *s1, const char *s2) -{ - size_t ns1 = strlen (s1) + 1, ns2 = strlen (s2) + 1; - size_t n = ns1 < ns2 ? ns1 : ns2; - int ret = 0; - - while (n--) - { - if ((ret = ((unsigned char) tolower (*s1) - - (unsigned char) tolower (*s2))) != 0) - break; - ++s1; - ++s2; - } - return ret; -} - static void do_one_test (impl_t *impl, const char *s1, const char *s2, int exp_result) { -- cgit v1.2.3