diff options
| author | Ulrich Drepper <drepper@redhat.com> | 1998-09-01 14:31:49 +0000 |
|---|---|---|
| committer | Ulrich Drepper <drepper@redhat.com> | 1998-09-01 14:31:49 +0000 |
| commit | 052b6a6c94cc330dfbc09ff7b5f03c943deb7ca2 (patch) | |
| tree | 0ef4d2730e6e20141e3b669b8a3614193200f3fc | |
| parent | 85c165befc61d049abe3cc443c275a210c569338 (diff) | |
| download | glibc-052b6a6c94cc330dfbc09ff7b5f03c943deb7ca2.tar.xz glibc-052b6a6c94cc330dfbc09ff7b5f03c943deb7ca2.zip | |
Update.
1998-08-09 Geoff Keating <geoffk@ozemail.com.au>
* sysdeps/powerpc/Makefile [subdir=elf]: Add new files split out of
dl-machine.h.
* sysdeps/powerpc/dl-machine.c: New file.
* sysdeps/powerpc/dl-machine.h: Move much stuff into separate
files. Revise ELF_PREFERRED_ADDRESS to take account of
the new mapping information (fixes bug involving huge bloated
web browser). Set ELF_MACHINE_PLTREL_OVERLAP.
* sysdeps/powerpc/dl-start.S: New file.
* elf/dl-load.c (_dl_map_object_from_fd): Initialise l_map_start,
l_map_end.
* elf/do-rel.h: Call elf_machine_rel only once (to save space).
* elf/dynamic-link.h: Allow PLT relocs to be in the middle of the
others. Call elf_dynamic_do_##reloc only once (to save even more
space).
* elf/link.h: Add new members l_map_start and l_map_end to keep
track of the memory map.
* elf/rtld.c (_dl_start): Initialise l_map_start for ld.so and
the executable.
1998-09-01 11:53 Ulrich Drepper <drepper@cygnus.com>
* debug/Makefile (catchsegv): We need not rewrite SOVER anymore.
Reported by Andreas Jaeger.
* posix/glob.h: Use __size_t instead of size_t in definitions and
make sure this is defined.
* manual/locale.texi: Almost complete rewrite. Document more functions
| -rw-r--r-- | ChangeLog | 32 | ||||
| -rw-r--r-- | debug/Makefile | 3 | ||||
| -rw-r--r-- | elf/dl-load.c | 9 | ||||
| -rw-r--r-- | elf/dynamic-link.h | 91 | ||||
| -rw-r--r-- | elf/link.h | 4 | ||||
| -rw-r--r-- | elf/rtld.c | 18 | ||||
| -rw-r--r-- | manual/examples/argp-ex1.c | 5 | ||||
| -rw-r--r-- | manual/examples/argp-ex2.c | 21 | ||||
| -rw-r--r-- | manual/examples/argp-ex3.c | 54 | ||||
| -rw-r--r-- | manual/examples/argp-ex4.c | 23 | ||||
| -rw-r--r-- | manual/startup.texi | 6 | ||||
| -rw-r--r-- | posix/glob.h | 23 | ||||
| -rw-r--r-- | sysdeps/powerpc/Makefile | 5 | ||||
| -rw-r--r-- | sysdeps/powerpc/dl-machine.c | 442 | ||||
| -rw-r--r-- | sysdeps/powerpc/dl-machine.h | 528 | ||||
| -rw-r--r-- | sysdeps/powerpc/dl-start.S | 111 |
16 files changed, 848 insertions, 527 deletions
@@ -1,6 +1,36 @@ +1998-08-09 Geoff Keating <geoffk@ozemail.com.au> + + * sysdeps/powerpc/Makefile [subdir=elf]: Add new files split out of + dl-machine.h. + * sysdeps/powerpc/dl-machine.c: New file. + * sysdeps/powerpc/dl-machine.h: Move much stuff into separate + files. Revise ELF_PREFERRED_ADDRESS to take account of + the new mapping information (fixes bug involving huge bloated + web browser). Set ELF_MACHINE_PLTREL_OVERLAP. + * sysdeps/powerpc/dl-start.S: New file. + + * elf/dl-load.c (_dl_map_object_from_fd): Initialise l_map_start, + l_map_end. + * elf/do-rel.h: Call elf_machine_rel only once (to save space). + * elf/dynamic-link.h: Allow PLT relocs to be in the middle of the + others. Call elf_dynamic_do_##reloc only once (to save even more + space). + * elf/link.h: Add new members l_map_start and l_map_end to keep + track of the memory map. + * elf/rtld.c (_dl_start): Initialise l_map_start for ld.so and + the executable. + +1998-09-01 11:53 Ulrich Drepper <drepper@cygnus.com> + + * debug/Makefile (catchsegv): We need not rewrite SOVER anymore. + Reported by Andreas Jaeger. + + * posix/glob.h: Use __size_t instead of size_t in definitions and + make sure this is defined. + 1998-09-01 10:34 Ulrich Drepper <drepper@cygnus.com> - * manual/locale.texi: Almost compelte rewrite. Document more functions + * manual/locale.texi: Almost complete rewrite. Document more functions and functionality. * manual/arith.texi: Correct reference. * manual/string.texi: Pretty printing. diff --git a/debug/Makefile b/debug/Makefile index fc1f950572..698ad07d12 100644 --- a/debug/Makefile +++ b/debug/Makefile @@ -44,8 +44,7 @@ include ../Rules $(objpfx)catchsegv: catchsegv.sh $(common-objpfx)soversions.mk \ $(common-objpfx)config.make - sed -e 's|@VERSION@|$(version)|' -e 's|@SLIB@|$(slibdir)|' \ - -e 's|@SOVER@|$(libSegFault.so-version)|' $< > $@.new + sed -e 's|@VERSION@|$(version)|' -e 's|@SLIB@|$(slibdir)|' $< > $@.new chmod 555 $@.new mv -f $@.new $@ diff --git a/elf/dl-load.c b/elf/dl-load.c index 81c1d8ba2e..e961cb0784 100644 --- a/elf/dl-load.c +++ b/elf/dl-load.c @@ -848,6 +848,11 @@ _dl_map_object_from_fd (char *name, int fd, char *realname, __mprotect ((caddr_t) (l->l_addr + c->mapend), loadcmds[nloadcmds - 1].allocend - c->mapend, 0); + + /* Remember which part of the address space this object uses. */ + l->l_map_start = c->mapstart + l->l_addr; + l->l_map_end = l->l_map_start + maplength; + goto postmap; } else @@ -857,6 +862,10 @@ _dl_map_object_from_fd (char *name, int fd, char *realname, ELF_FIXED_ADDRESS (loader, c->mapstart); } + /* Remember which part of the address space this object uses. */ + l->l_map_start = c->mapstart + l->l_addr; + l->l_map_end = l->l_map_start + maplength; + while (c < &loadcmds[nloadcmds]) { if (c->mapend > c->mapstart) diff --git a/elf/dynamic-link.h b/elf/dynamic-link.h index 9d7ae3d3fa..9e2ca03543 100644 --- a/elf/dynamic-link.h +++ b/elf/dynamic-link.h @@ -83,60 +83,75 @@ elf_get_dynamic_info (ElfW(Dyn) *dyn, #ifdef ELF_MACHINE_PLTREL_OVERLAP #define _ELF_DYNAMIC_DO_RELOC(RELOC, reloc, map, lazy) \ do { \ - ElfW(Addr) r_addr, r_size, p_addr, p_size; \ + struct { ElfW(Addr) start, size; int lazy; } ranges[3]; \ + int ranges_index; \ + \ + ranges[0].lazy = ranges[2].lazy = 0; \ + ranges[1].lazy = 1; \ + ranges[0].size = ranges[1].size = ranges[2].size = 0; \ + \ if ((map)->l_info[DT_##RELOC]) \ { \ - r_addr = (map)->l_info[DT_##RELOC]->d_un.d_ptr; \ - r_size = (map)->l_info[DT_##RELOC##SZ]->d_un.d_val; \ - if ((map)->l_info[DT_PLTREL] && \ - (map)->l_info[DT_PLTREL]->d_un.d_val == DT_##RELOC) \ - { \ - p_addr = (map)->l_info[DT_JMPREL]->d_un.d_ptr; \ - p_size = (map)->l_info[DT_PLTRELSZ]->d_un.d_val; \ - if (r_addr <= p_addr && r_addr+r_size > p_addr) \ - { \ - ElfW(Addr) r2_addr, r2_size; \ - r2_addr = p_addr + p_size; \ - if (r2_addr < r_addr + r_size) \ - { \ - r2_size = r_addr + r_size - r2_addr; \ - elf_dynamic_do_##reloc ((map), r2_addr, r2_size, 0); \ - } \ - r_size = p_addr - r_addr; \ - } \ - } \ - \ - elf_dynamic_do_##reloc ((map), r_addr, r_size, 0); \ - if (p_addr) \ - elf_dynamic_do_##reloc ((map), p_addr, p_size, (lazy)); \ + ranges[0].start = (map)->l_info[DT_##RELOC]->d_un.d_ptr; \ + ranges[0].size = (map)->l_info[DT_##RELOC##SZ]->d_un.d_val; \ } \ - else if ((map)->l_info[DT_PLTREL] && \ - (map)->l_info[DT_PLTREL]->d_un.d_val == DT_##RELOC) \ - { \ - p_addr = (map)->l_info[DT_JMPREL]->d_un.d_ptr; \ - p_size = (map)->l_info[DT_PLTRELSZ]->d_un.d_val; \ \ - elf_dynamic_do_##reloc ((map), p_addr, p_size, (lazy)); \ + if ((lazy) \ + && (map)->l_info[DT_PLTREL] \ + && (map)->l_info[DT_PLTREL]->d_un.d_val == DT_##RELOC) \ + { \ + ranges[1].start = (map)->l_info[DT_JMPREL]->d_un.d_ptr; \ + ranges[1].size = (map)->l_info[DT_PLTRELSZ]->d_un.d_val; \ + ranges[2].start = ranges[1].start + ranges[1].size; \ + ranges[2].size = ranges[0].start + ranges[0].size - ranges[2].start; \ + ranges[0].size = ranges[1].start - ranges[0].start; \ } \ + \ + for (ranges_index = 0; ranges_index < 3; ++ranges_index) \ + elf_dynamic_do_##reloc ((map), \ + ranges[ranges_index].start, \ + ranges[ranges_index].size, \ + ranges[ranges_index].lazy); \ } while (0) #else #define _ELF_DYNAMIC_DO_RELOC(RELOC, reloc, map, lazy) \ do { \ + struct { ElfW(Addr) start, size; int lazy; } ranges[2]; \ + int ranges_index; \ + ranges[0].lazy = 0; \ + ranges[1].lazy = 1; \ + ranges[0].size = ranges[1].size = 0; \ + ranges[0].start = 0; \ + \ if ((map)->l_info[DT_##RELOC]) \ { \ - ElfW(Addr) r_addr, r_size; \ - r_addr = (map)->l_info[DT_##RELOC]->d_un.d_ptr; \ - r_size = (map)->l_info[DT_##RELOC##SZ]->d_un.d_val; \ - elf_dynamic_do_##reloc ((map), r_addr, r_size, 0); \ + ranges[0].start = (map)->l_info[DT_##RELOC]->d_un.d_ptr; \ + ranges[0].size = (map)->l_info[DT_##RELOC##SZ]->d_un.d_val; \ } \ if ((map)->l_info[DT_PLTREL] && \ (map)->l_info[DT_PLTREL]->d_un.d_val == DT_##RELOC) \ { \ - ElfW(Addr) p_addr, p_size; \ - p_addr = (map)->l_info[DT_JMPREL]->d_un.d_ptr; \ - p_size = (map)->l_info[DT_PLTRELSZ]->d_un.d_val; \ - elf_dynamic_do_##reloc ((map), p_addr, p_size, (lazy)); \ + ElfW(Addr) start = (map)->l_info[DT_JMPREL]->d_un.d_ptr; \ + \ + if (lazy \ + /* This test does not only detect whether the relocation \ + sections are in the right order, it also checks whether \ + there is a DT_REL/DT_RELA section. */ \ + || ranges[0].start + ranges[0].size != start) \ + { \ + ranges[1].start = start; \ + ranges[1].size = (map)->l_info[DT_PLTRELSZ]->d_un.d_val; \ + } \ + else \ + /* Combine processing the sections. */ \ + ranges[0].size += (map)->l_info[DT_PLTRELSZ]->d_un.d_val; \ } \ + \ + for (ranges_index = 0; ranges_index < 2; ++ranges_index) \ + elf_dynamic_do_##reloc ((map), \ + ranges[ranges_index].start, \ + ranges[ranges_index].size, \ + ranges[ranges_index].lazy); \ } while (0) #endif diff --git a/elf/link.h b/elf/link.h index 40f7435a84..e31dd2dd65 100644 --- a/elf/link.h +++ b/elf/link.h @@ -164,6 +164,10 @@ struct link_map /* String specifying the path where this object was found. */ const char *l_origin; + + /* Start and finish of memory map for this object. l_map_start + need not be the same as l_addr. */ + ElfW(Addr) l_map_start, l_map_end; }; #endif /* link.h */ diff --git a/elf/rtld.c b/elf/rtld.c index 3ae51e68ab..b25fb20fd3 100644 --- a/elf/rtld.c +++ b/elf/rtld.c @@ -165,6 +165,10 @@ _dl_start (void *arg) _dl_rtld_map.l_info[DT_RPATH]->d_un.d_val); } +/* Don't bother trying to work out how ld.so is mapped in memory. */ + _dl_rtld_map.l_map_start = ~0; + _dl_rtld_map.l_map_end = ~0; + /* Call the OS-dependent function to set up life so we can do things like file access. It will call `dl_main' (below) to do all the real work of the dynamic linker, and then unwind our frame and run the user @@ -432,6 +436,11 @@ of this helper program; chances are you did not intend to run this program.\n\ information for the program. */ } + /* It is not safe to load stuff after the main program. */ + main_map->l_map_end = ~0; + /* Perhaps the executable has no PT_LOAD header entries at all. */ + main_map->l_map_start = ~0; + /* Scan the program header table for the dynamic section. */ for (ph = phdr; ph < &phdr[phent]; ++ph) switch (ph->p_type) @@ -474,6 +483,15 @@ of this helper program; chances are you did not intend to run this program.\n\ has_interp = 1; break; + case PT_LOAD: + /* Remember where the main program starts in memory. */ + { + ElfW(Addr) mapstart; + mapstart = main_map->l_addr + (ph->p_vaddr & ~(ph->p_align - 1)); + if (main_map->l_map_start > mapstart) + main_map->l_map_start = mapstart; + } + break; } if (! _dl_rtld_map.l_libname && _dl_rtld_map.l_name) { diff --git a/manual/examples/argp-ex1.c b/manual/examples/argp-ex1.c index c87ebbb532..50ac0ed978 100644 --- a/manual/examples/argp-ex1.c +++ b/manual/examples/argp-ex1.c @@ -1,5 +1,10 @@ /* Argp example #1 -- a minimal program using argp */ +/* This is (probably) the smallest possible program that + uses argp. It won't do much except give an error + messages and exit when there are any arguments, and print + a (rather pointless) messages for --help. */ + #include <argp.h> int main (int argc, char **argv) diff --git a/manual/examples/argp-ex2.c b/manual/examples/argp-ex2.c index d1b149b494..55f59f2ab8 100644 --- a/manual/examples/argp-ex2.c +++ b/manual/examples/argp-ex2.c @@ -1,11 +1,30 @@ /* Argp example #2 -- a pretty minimal program using argp */ +/* This program doesn't use any options or arguments, but uses + argp to be compliant with the GNU standard command line + format. + + In addition to making sure no arguments are given, and + implementing a --help option, this example will have a + --version option, and will put the given documentation string + and bug address in the --help output, as per GNU standards. + + The variable ARGP contains the argument parser specification; + adding fields to this structure is the way most parameters are + passed to argp_parse (the first three fields are usually used, + but not in this small program). There are also two global + variables that argp knows about defined here, + ARGP_PROGRAM_VERSION and ARGP_PROGRAM_BUG_ADDRESS (they are + global variables becuase they will almost always be constant + for a given program, even if it uses different argument + parsers for various tasks). */ + #include <argp.h> const char *argp_program_version = "argp-ex2 1.0"; const char *argp_program_bug_address = - "<bug-gnu-utils@@prep.ai.mit.edu>"; + "<bug-gnu-utils@@gnu.org>"; /* Program documentation. */ static char doc[] = diff --git a/manual/examples/argp-ex3.c b/manual/examples/argp-ex3.c index 363ee59e11..87d993f8ae 100644 --- a/manual/examples/argp-ex3.c +++ b/manual/examples/argp-ex3.c @@ -1,11 +1,63 @@ /* Argp example #3 -- a program with options and arguments using argp */ +/* This program uses the same features as example 2, and uses options and + arguments. + + We now use the first four fields in ARGP, so here's a description of them: + OPTIONS -- A pointer to a vector of struct argp_option (see below) + PARSER -- A function to parse a single option, called by argp + ARGS_DOC -- A string describing how the non-option arguments should look + DOC -- A descriptive string about this program; if it contains a + vertical tab character (\v), the part after it will be + printed *following* the options + + The function PARSER takes the following arguments: + KEY -- An integer specifying which option this is (taken + from the KEY field in each struct argp_option), or + a special key specifying something else; the only + special keys we use here are ARGP_KEY_ARG, meaning + a non-option argument, and ARGP_KEY_END, meaning + that all argumens have been parsed + ARG -- For an option KEY, the string value of its + argument, or NULL if it has none + STATE-- A pointer to a struct argp_state, containing + various useful information about the parsing state; used here + are the INPUT field, which reflects the INPUT argument to + argp_parse, and the ARG_NUM field, which is the number of the + current non-option argument being parsed + It should return either 0, meaning success, ARGP_ERR_UNKNOWN, meaning the + given KEY wasn't recognized, or an errno value indicating some other + error. + + Note that in this example, main uses a structure to communicate with the + parse_opt function, a pointer to which it passes in the INPUT argument to + argp_parse. Of course, it's also possible to use global variables + instead, but this is somewhat more flexible. + + The OPTIONS field contains a pointer to a vector of struct argp_option's; + that structure has the following fields (if you assign your option + structures using array initialization like this example, unspecified + fields will be defaulted to 0, and need not be specified): + NAME -- The name of this option's long option (may be zero) + KEY -- The KEY to pass to the PARSER function when parsing this option, + *and* the name of this option's short option, if it is a + printable ascii character + ARG -- The name of this option's argument, if any + FLAGS -- Flags describing this option; some of them are: + OPTION_ARG_OPTIONAL -- The argument to this option is optional + OPTION_ALIAS -- This option is an alias for the + previous option + OPTION_HIDDEN -- Don't show this option in --help output + DOC -- A documentation string for this option, shown in --help output + + An options vector should be terminated by an option with all fields zero. */ + #include <argp.h> const char *argp_program_version = "argp-ex3 1.0"; const char *argp_program_bug_address = - "<bug-gnu-utils@@prep.ai.mit.edu>"; + "<bug-gnu-utils@@gnu.org>"; /* Program documentation. */ static char doc[] = diff --git a/manual/examples/argp-ex4.c b/manual/examples/argp-ex4.c index 24dd417a81..fa5a8d00ec 100644 --- a/manual/examples/argp-ex4.c +++ b/manual/examples/argp-ex4.c @@ -1,5 +1,28 @@ /* Argp example #4 -- a program with somewhat more complicated options */ +/* This program uses the same features as example 3, but has more + options, and somewhat more structure in the -help output. It + also shows how you can `steal' the remainder of the input + arguments past a certain point, for programs that accept a + list of items. It also shows the special argp KEY value + ARGP_KEY_NO_ARGS, which is only given if no non-option + arguments were supplied to the program. + + For structuring the help output, two features are used, + *headers* which are entries in the options vector with the + first four fields being zero, and a two part documentation + string (in the variable DOC), which allows documentation both + before and after the options; the two parts of DOC are + separated by a vertical-tab character ('\v', or '\013'). By + convention, the documentation before the options is just a + short string saying what the program does, and that afterwards + is longer, describing the behavior in more detail. All + documentation strings are automatically filled for output, + although newlines may be included to force a line break at a + particular point. All documenation strings are also passed to + the `gettext' function, for possible translation into the + current locale. */ + #include <stdlib.h> #include <error.h> #include <argp.h> diff --git a/manual/startup.texi b/manual/startup.texi index dd21c89e6f..bea6c39676 100644 --- a/manual/startup.texi +++ b/manual/startup.texi @@ -82,7 +82,7 @@ allow this three-argument form, so to be portable it is best to write * Parsing Program Arguments:: Ways to parse program options and arguments. @end menu -@node Argument Syntax +@node Argument Syntax, Parsing Program Arguments, , Program Arguments @subsection Program Argument Syntax Conventions @cindex program argument syntax @cindex syntax, for program arguments @@ -154,7 +154,7 @@ accept an argument that is itself optional. Eventually, the GNU system will provide completion for long option names in the shell. -@node Parsing Program Arguments +@node Parsing Program Arguments, , Argument Syntax, Program Arguments @subsection Parsing Program Arguments @cindex program arguments, parsing @@ -188,7 +188,7 @@ it does more of the dirty work for you. @node Suboptions, Suboptions Example, Argp, Parsing Program Arguments @c This is a @section so that it's at the same level as getopt and argp -@section Parsing of Suboptions +@subsubsection Parsing of Suboptions Having a single level of options is sometimes not enough. There might be too many options which have to be available or a set of options is diff --git a/posix/glob.h b/posix/glob.h index 609f2177e5..f4c0974011 100644 --- a/posix/glob.h +++ b/posix/glob.h @@ -43,6 +43,21 @@ extern "C" { # define __ptr_t char * #endif /* C++ or ANSI C. */ +/* We need `size_t' for the following definitions. */ +#ifndef __size_t +# if defined __GNUC__ && __GNUC__ >= 2 +typedef __SIZE_TYPE__ __size_t; +# else +/* This is a guess. */ +typedef unsigned long int __size_t; +# endif +#else +/* The GNU CC stddef.h version defines __size_t as empty. We need a real + definition. */ +# undef __size_t +# define __size_t size_t +#endif + /* Bits set in the FLAGS argument to `glob'. */ #define GLOB_ERR (1 << 0)/* Return on read errors. */ #define GLOB_MARK (1 << 1)/* Append a slash to each name. */ @@ -90,9 +105,9 @@ struct stat; #endif typedef struct { - size_t gl_pathc; /* Count of paths matched by the pattern. */ + __size_t gl_pathc; /* Count of paths matched by the pattern. */ char **gl_pathv; /* List of matched pathnames. */ - size_t gl_offs; /* Slots to reserve in `gl_pathv'. */ + __size_t gl_offs; /* |
