diff options
| author | Florian Weimer <fweimer@redhat.com> | 2021-05-03 08:12:11 +0200 |
|---|---|---|
| committer | Florian Weimer <fweimer@redhat.com> | 2021-05-03 08:15:04 +0200 |
| commit | 08a31ef923c51dc5ff2ef815730de0ba4d591ae3 (patch) | |
| tree | b86649471801e4039a1d6c79e6c82b1aaf53bdee | |
| parent | eef936eb458e5dfccceee6d3c4220f9a1c62832b (diff) | |
| download | glibc-08a31ef923c51dc5ff2ef815730de0ba4d591ae3.tar.xz glibc-08a31ef923c51dc5ff2ef815730de0ba4d591ae3.zip | |
nptl: Move cnd_timedwait into libc
The symbol was moved using scripts/move-symbol-to-libc.py.
The __pthread_cond_timedwait@@GLIBC_PRIVATE symbol is no longer
neded, so remove that as well.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
66 files changed, 89 insertions, 44 deletions
diff --git a/nptl/Versions b/nptl/Versions index b18709c8e1..1aecde43ed 100644 --- a/nptl/Versions +++ b/nptl/Versions @@ -131,6 +131,7 @@ libc { cnd_destroy; cnd_init; cnd_signal; + cnd_timedwait; thrd_current; thrd_equal; thrd_sleep; @@ -164,6 +165,7 @@ libc { cnd_destroy; cnd_init; cnd_signal; + cnd_timedwait; pthread_cond_clockwait; pthread_condattr_getclock; pthread_condattr_getpshared; @@ -226,7 +228,6 @@ libc { __pthread_cleanup_pop; __pthread_cleanup_push; __pthread_cleanup_upto; - __pthread_cond_timedwait; # Used by the C11 threads. __pthread_cond_wait; # Used by the C11 threads. __pthread_current_priority; __pthread_exit; @@ -378,7 +379,6 @@ libpthread { # C11 thread symbols. GLIBC_2.28 { - cnd_timedwait; cnd_wait; mtx_destroy; mtx_init; diff --git a/nptl/pthread_cond_wait.c b/nptl/pthread_cond_wait.c index 5a1642b932..89ea231554 100644 --- a/nptl/pthread_cond_wait.c +++ b/nptl/pthread_cond_wait.c @@ -646,9 +646,10 @@ ___pthread_cond_timedwait64 (pthread_cond_t *cond, pthread_mutex_t *mutex, #if __TIMESIZE == 64 strong_alias (___pthread_cond_timedwait64, ___pthread_cond_timedwait) #else -versioned_symbol (libc, ___pthread_cond_timedwait64, - __pthread_cond_timedwait64, GLIBC_PRIVATE); libc_hidden_ver (___pthread_cond_timedwait64, __pthread_cond_timedwait64) +#ifndef SHARED +strong_alias (___pthread_cond_timedwait64, __pthread_cond_timedwait64) +#endif int ___pthread_cond_timedwait (pthread_cond_t *cond, pthread_mutex_t *mutex, @@ -662,8 +663,9 @@ ___pthread_cond_timedwait (pthread_cond_t *cond, pthread_mutex_t *mutex, versioned_symbol (libc, ___pthread_cond_timedwait, pthread_cond_timedwait, GLIBC_2_3_2); libc_hidden_ver (___pthread_cond_timedwait, __pthread_cond_timedwait) -versioned_symbol (libc, ___pthread_cond_timedwait, - __pthread_cond_timedwait, GLIBC_PRIVATE); +#ifndef SHARED +strong_alias (___pthread_cond_timedwait, __pthread_cond_timedwait) +#endif /* See __pthread_cond_wait_common. */ int diff --git a/sysdeps/pthread/Makefile b/sysdeps/pthread/Makefile index fcc5f841fd..4928f91f04 100644 --- a/sysdeps/pthread/Makefile +++ b/sysdeps/pthread/Makefile @@ -34,7 +34,7 @@ routines += thrd_current thrd_equal thrd_sleep thrd_yield libpthread-routines += thrd_create thrd_detach thrd_exit thrd_join \ mtx_destroy mtx_init mtx_lock mtx_timedlock \ mtx_trylock mtx_unlock \ - cnd_timedwait cnd_wait \ + cnd_wait \ tss_create tss_delete tss_get tss_set $(libpthread-routines-var) += \ @@ -43,6 +43,7 @@ $(libpthread-routines-var) += \ cnd_destroy \ cnd_init \ cnd_signal \ + cnd_timedwait \ tests += tst-cnd-basic tst-mtx-trylock tst-cnd-broadcast \ tst-cnd-timedwait tst-thrd-detach tst-mtx-basic tst-thrd-sleep \ diff --git a/sysdeps/unix/sysv/linux/aarch64/libc.abilist b/sysdeps/unix/sysv/linux/aarch64/libc.abilist index defb9dc974..5c8c6dbff5 100644 --- a/sysdeps/unix/sysv/linux/aarch64/libc.abilist +++ b/sysdeps/unix/sysv/linux/aarch64/libc.abilist @@ -2203,6 +2203,7 @@ GLIBC_2.28 cnd_broadcast F GLIBC_2.28 cnd_destroy F GLIBC_2.28 cnd_init F GLIBC_2.28 cnd_signal F +GLIBC_2.28 cnd_timedwait F GLIBC_2.28 fcntl64 F GLIBC_2.28 renameat2 F GLIBC_2.28 statx F @@ -2259,6 +2260,7 @@ GLIBC_2.34 cnd_broadcast F GLIBC_2.34 cnd_destroy F GLIBC_2.34 cnd_init F GLIBC_2.34 cnd_signal F +GLIBC_2.34 cnd_timedwait F GLIBC_2.34 pthread_cond_clockwait F GLIBC_2.34 pthread_condattr_getclock F GLIBC_2.34 pthread_condattr_getpshared F diff --git a/sysdeps/unix/sysv/linux/aarch64/libpthread.abilist b/sysdeps/unix/sysv/linux/aarch64/libpthread.abilist index 2a03782c65..ad08f4362a 100644 --- a/sysdeps/unix/sysv/linux/aarch64/libpthread.abilist +++ b/sysdeps/unix/sysv/linux/aarch64/libpthread.abilist @@ -69,7 +69,6 @@ GLIBC_2.17 sem_unlink F GLIBC_2.17 sem_wait F GLIBC_2.18 pthread_getattr_default_np F GLIBC_2.18 pthread_setattr_default_np F -GLIBC_2.28 cnd_timedwait F GLIBC_2.28 cnd_wait F GLIBC_2.28 mtx_destroy F GLIBC_2.28 mtx_init F diff --git a/sysdeps/unix/sysv/linux/alpha/libc.abilist b/sysdeps/unix/sysv/linux/alpha/libc.abilist index 46fb382ab6..712fe8fd85 100644 --- a/sysdeps/unix/sysv/linux/alpha/libc.abilist +++ b/sysdeps/unix/sysv/linux/alpha/libc.abilist @@ -2096,6 +2096,7 @@ GLIBC_2.28 cnd_broadcast F GLIBC_2.28 cnd_destroy F GLIBC_2.28 cnd_init F GLIBC_2.28 cnd_signal F +GLIBC_2.28 cnd_timedwait F GLIBC_2.28 fcntl64 F GLIBC_2.28 renameat2 F GLIBC_2.28 statx F @@ -2340,6 +2341,7 @@ GLIBC_2.34 cnd_broadcast F GLIBC_2.34 cnd_destroy F GLIBC_2.34 cnd_init F GLIBC_2.34 cnd_signal F +GLIBC_2.34 cnd_timedwait F GLIBC_2.34 pthread_cond_clockwait F GLIBC_2.34 pthread_condattr_getclock F GLIBC_2.34 pthread_condattr_getpshared F diff --git a/sysdeps/unix/sysv/linux/alpha/libpthread.abilist b/sysdeps/unix/sysv/linux/alpha/libpthread.abilist index 95cf8307c1..687b742199 100644 --- a/sysdeps/unix/sysv/linux/alpha/libpthread.abilist +++ b/sysdeps/unix/sysv/linux/alpha/libpthread.abilist @@ -69,7 +69,6 @@ GLIBC_2.2 pthread_yield F GLIBC_2.2 sem_timedwait F GLI |
