diff options
| author | Florian Weimer <fweimer@redhat.com> | 2021-05-03 08:12:11 +0200 |
|---|---|---|
| committer | Florian Weimer <fweimer@redhat.com> | 2021-05-03 08:14:38 +0200 |
| commit | 3eab466e566c5c28cbec55b092fe21e134baac22 (patch) | |
| tree | 0ac64e4963ae00618a3b492df547c2d85a78ac13 | |
| parent | f11c293a4c3c637c3eecae00b341c578f52bdc46 (diff) | |
| download | glibc-3eab466e566c5c28cbec55b092fe21e134baac22.tar.xz glibc-3eab466e566c5c28cbec55b092fe21e134baac22.zip | |
nptl: Move cnd_init into libc
The symbol was moved using scripts/move-symbol-to-libc.py.
The __pthread_cond_init@@GLIBC_PRIVATE symbol is no longer
neded, so remove that as well.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
64 files changed, 78 insertions, 33 deletions
diff --git a/nptl/Versions b/nptl/Versions index 08fcebacb7..3b11cc1797 100644 --- a/nptl/Versions +++ b/nptl/Versions @@ -129,6 +129,7 @@ libc { call_once; cnd_broadcast; cnd_destroy; + cnd_init; thrd_current; thrd_equal; thrd_sleep; @@ -160,6 +161,7 @@ libc { call_once; cnd_broadcast; cnd_destroy; + cnd_init; pthread_cond_clockwait; pthread_condattr_getclock; pthread_condattr_getpshared; @@ -222,7 +224,6 @@ libc { __pthread_cleanup_pop; __pthread_cleanup_push; __pthread_cleanup_upto; - __pthread_cond_init; # Used by the C11 threads. __pthread_cond_signal; # Used by the C11 threads. __pthread_cond_timedwait; # Used by the C11 threads. __pthread_cond_wait; # Used by the C11 threads. @@ -376,7 +377,6 @@ libpthread { # C11 thread symbols. GLIBC_2.28 { - cnd_init; cnd_signal; cnd_timedwait; cnd_wait; diff --git a/sysdeps/pthread/Makefile b/sysdeps/pthread/Makefile index d7cfce2d33..6ef49cd4b4 100644 --- a/sysdeps/pthread/Makefile +++ b/sysdeps/pthread/Makefile @@ -34,13 +34,14 @@ routines += thrd_current thrd_equal thrd_sleep thrd_yield libpthread-routines += thrd_create thrd_detach thrd_exit thrd_join \ mtx_destroy mtx_init mtx_lock mtx_timedlock \ mtx_trylock mtx_unlock \ - cnd_init cnd_signal cnd_timedwait cnd_wait \ + cnd_signal cnd_timedwait cnd_wait \ tss_create tss_delete tss_get tss_set $(libpthread-routines-var) += \ call_once \ cnd_broadcast \ cnd_destroy \ + cnd_init \ tests += tst-cnd-basic tst-mtx-trylock tst-cnd-broadcast \ tst-cnd-timedwait tst-thrd-detach tst-mtx-basic tst-thrd-sleep \ diff --git a/sysdeps/pthread/cnd_init.c b/sysdeps/pthread/cnd_init.c index 044cc1d173..791a9ebf62 100644 --- a/sysdeps/pthread/cnd_init.c +++ b/sysdeps/pthread/cnd_init.c @@ -17,11 +17,12 @@ <https://www.gnu.org/licenses/>. */ #include <stdalign.h> +#include <shlib-compat.h> #include "thrd_priv.h" int -cnd_init (cnd_t *cond) +__cnd_init (cnd_t *cond) { _Static_assert (sizeof (cnd_t) == sizeof (pthread_cond_t), "(sizeof (cnd_t) != sizeof (pthread_cond_t)"); @@ -31,3 +32,11 @@ cnd_init (cnd_t *cond) int err_code = __pthread_cond_init ((pthread_cond_t *)cond, NULL); return thrd_err_map (err_code); } +#if PTHREAD_IN_LIBC +versioned_symbol (libc, __cnd_init, cnd_init, GLIBC_2_34); +# if OTHER_SHLIB_COMPAT (libpthread, GLIBC_2_28, GLIBC_2_34) +compat_symbol (libpthread, __cnd_init, cnd_init, GLIBC_2_28); +# endif +#else /* !PTHREAD_IN_LIBC */ +strong_alias (__cnd_init, cnd_init) +#endif diff --git a/sysdeps/unix/sysv/linux/aarch64/libc.abilist b/sysdeps/unix/sysv/linux/aarch64/libc.abilist index b7236ac82e..82dc863ef3 100644 --- a/sysdeps/unix/sysv/linux/aarch64/libc.abilist +++ b/sysdeps/unix/sysv/linux/aarch64/libc.abilist @@ -2201,6 +2201,7 @@ GLIBC_2.27 wcstof64x_l F GLIBC_2.28 call_once F GLIBC_2.28 cnd_broadcast F GLIBC_2.28 cnd_destroy F +GLIBC_2.28 cnd_init F GLIBC_2.28 fcntl64 F GLIBC_2.28 renameat2 F GLIBC_2.28 statx F @@ -2255,6 +2256,7 @@ GLIBC_2.34 __pthread_unwind_next F GLIBC_2.34 call_once F GLIBC_2.34 cnd_broadcast F GLIBC_2.34 cnd_destroy F +GLIBC_2.34 cnd_init F GLIBC_2.34 pthread_cond_clockwait F GLIBC_2.34 pthread_condattr_getclock F GLIBC_2.34 pthread_condattr_getpshared F diff --git a/sysdeps/unix/sysv/linux/aarch64/libpthread.abilist b/sysdeps/unix/sysv/linux/aarch64/libpthread.abilist index 2fc70b29d0..93724a8ff9 100644 --- a/sysdeps/unix/sysv/linux/aarch64/libpthread.abilist +++ b/sysdeps/unix/sysv/linux/aarch64/libpthread.abilist @@ -69,7 +69,6 @@ GLIBC_2.17 sem_unlink F GLIBC_2.17 sem_wait F GLIBC_2.18 pthread_getattr_default_np F GLIBC_2.18 pthread_setattr_default_np F -GLIBC_2.28 cnd_init F GLIBC_2.28 cnd_signal F GLIBC_2.28 cnd_timedwait F GLIBC_2.28 cnd_wait F diff --git a/sysdeps/unix/sysv/linux/alpha/libc.abilist b/sysdeps/unix/sysv/linux/alpha/libc.abilist index af30149d8d..8329679f29 100644 --- a/sysdeps/unix/sysv/linux/alpha/libc.abilist +++ b/sysdeps/unix/sysv/linux/alpha/libc.abilist @@ -2094,6 +2094,7 @@ GLIBC_2.27 wcstof64x_l F GLIBC_2.28 call_once F GLIBC_2.28 cnd_broadcast F GLIBC_2.28 cnd_destroy F +GLIBC_2.28 cnd_init F GLIBC_2.28 fcntl64 F GLIBC_2.28 renameat2 F GLIBC_2.28 statx F @@ -2336,6 +2337,7 @@ GLIBC_2.34 __pthread_unwind_next F GLIBC_2.34 call_once F GLIBC_2.34 cnd_broadcast F GLIBC_2.34 cnd_destroy F +GLIBC_2.34 cnd_init F GLIBC_2.34 pthread_cond_clockwait F GLIBC_2.34 pthread_condattr_getclock F GLIBC_2.34 pthread_condattr_getpshared F diff --git a/sysdeps/unix/sysv/linux/alpha/libpthread.abilist b/sysdeps/unix/sysv/linux/alpha/libpthread.abilist index be6670f777..fa03817bb4 100644 --- a/sysdeps/unix/sysv/linux/alpha/libpthread.abilist +++ b/sysdeps/unix/sysv/linux/alpha/libpthread.abilist @@ -69,7 +69,6 @@ GLIBC_2.2 pthread_yield F GLIBC_2.2 sem_timedwait F GLIBC_2.2.3 __libpthread_version_placeholder F GLIBC_2.2.6 __libpthread_version_placeholder F -GLIBC_2.28 cnd_init F GLIBC_2.28 cnd_signal F GLIBC_2.28 cnd_timedwait F GLIBC_2.28 cnd_wait F diff --git a/sysdeps/unix/sysv/linux/arc/libc.abilist b/sysdeps/unix/sysv/linux/arc/libc.abilist index 2c3bbd8fb2..21a20f8bfb 100644 --- a/sysdeps/unix/sysv/linux/arc/libc.abilist +++ b/sysdeps/unix/sysv/linux/arc/libc.abilist @@ -628,6 +628,7 @@ GLIBC_2.32 closedir F GLIBC_2.32 closelog F GLIBC_2.32 cnd_broadcast F GLIBC_2.32 cnd_destroy F +GLIBC_2.32 cnd_init F |
