Add __v*printf_internal with flags arguments

There are a lot more printf variants than there are scanf variants,
and the code for setting up and tearing down their custom FILE
variants around the call to __vf(w)printf is more complicated and
variable.  Therefore, I have added _internal versions of all the
v*printf variants, rather than introducing helper routines so that
they can all directly call __vf(w)printf_internal, as was done with
scanf.

As with the scanf changes, in this patch the _internal functions still
look at the environmental mode bits and all callers pass 0 for the
flags parameter.

Several of the affected public functions had _IO_ name aliases that
were not exported (but, in one case, appeared in libio.h anyway);
I was originally planning to leave them as aliases to avoid having
to touch internal callers, but it turns out ldbl_*_alias only work
for exported symbols, so they've all been removed instead.  It also
turns out there were hardly any internal callers.  _IO_vsprintf and
_IO_vfprintf *are* exported, so those two stick around.

Summary for the changes to each of the affected symbols:

  _IO_vfprintf, _IO_vsprintf:
    All internal calls removed, thus the internal declarations, as well
    as uses of libc_hidden_proto and libc_hidden_def, were also removed.
    The external symbol is now exposed via uses of ldbl_strong_alias
    to __vfprintf_internal and __vsprintf_internal, respectively.

  _IO_vasprintf, _IO_vdprintf, _IO_vsnprintf,
  _IO_vfwprintf, _IO_vswprintf,
  _IO_obstack_vprintf, _IO_obstack_printf:
    All internal calls removed, thus declaration in internal headers
    were also removed.  They were never exported, so there are no
    aliases tying them to the internal functions.  I.e.: entirely gone.

  __vsnprintf:
    Internal calls were always preceded by macros such as
      #define __vsnprintf _IO_vsnprintf, and
      #define __vsnprintf vsnprintf
    The macros were removed and their uses replaced with calls to the
    new internal function __vsnprintf_internal.  Since there were no
    internal calls, the internal declaration was also removed.  The
    external symbol is preserved with ldbl_weak_alias to ___vsnprintf.

  __vfwprintf:
    All internal calls converted into calls to __vfwprintf_internal,
    thus the internal declaration was removed.  The function is now a
    wrapper that calls __vfwprintf_internal.  The external symbol is
    preserved.

  __vswprintf:
    Similarly, but no external symbol.

  __vasprintf, __vdprintf, __vfprintf, __vsprintf:
    New internal wrappers.  Not exported.

  vasprintf, vdprintf, vfprintf, vsprintf, vsnprintf,
  vfwprintf, vswprintf,
  obstack_vprintf, obstack_printf:
    These functions used to be aliases to the respective _IO_* function,
    they are now aliases to their respective __* functions.

Tested for powerpc and powerpc64le.

45 files changed, 2632 insertions, 2465 deletions

diff --git a/ChangeLog b/ChangeLog
index 9ad1f41068..e96f3c60fe 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,88 @@
 2018-12-05  Zack Weinberg  <zackw@panix.com>
 	    Gabriel F. T. Gomes  <gabriel@inconstante.eti.br>
 
+	* libio/libioP.h (__vfprintf_internal, __vfwprintf_internal)
+	(__vasprintf_internal, __vdprintf_internal, __obstack_vprintf_internal)
+	(__vsprintf_internal, __vsnprintf_internal, __vswprintf_internal):
+	New functions.
+	(PRINTF_LDBL_IS_DBL, PRINTF_FORTIFY): New constants.
+	(_IO_vasprintf, _IO_vdprintf, _IO_vsnprintf): Remove prototypes.
+
+	* stdio-common/vfprintf-internal.c: Rename from vfprintf.c.
+	Include wctype.h here if COMPILE_WPRINTF is defined.
+	Define __vfprintf_internal or __vfwprintf_internal, depending
+	on COMPILE_WPRINTF.
+	Temporarily, on entry to this function, update mode_flags
+	according to the environmental settings corresponding to
+	PRINTF_LDBL_IS_DBL and PRINTF_FORTIFY.
+	Throughout, check mode_flags instead of __ldbl_is_dbl and
+	_IO_FLAGS2_FORTIFY on the destination FILE.
+	* stdio-common/vfwprintf-internal.c: Rename from vfwprintf.c.
+	Include vfprintf-internal.c.  Don't include wctype.h.
+	* stdio-common/vfprintf.c: New file.  Just define __vfprintf
+	as a wrapper around __vfprintf_internal, with aliases _IO_vfprintf
+	and vfprintf.
+	* stdio-common/vfwprintf.c: New file.  Just define __vfwprintf
+	as a wrapper around __vfwprintf_internal, with aliases _IO_vfwprintf
+	and vfwprintf.
+	* stdio-common/Makefile: Add vfprintf-internal and vfwprintf-internal.
+
+	* libio/iovdprintf.c (_IO_vdprintf): Rename to __vdprintf_internal
+	and add mode_flags argument; use __vfprintf_internal.
+	(__vdprintf): New function.  Alias vdprintf to this.
+	* libio/iovsprintf.c (_IO_vsprintf, __vsprintf): Similarly.
+	* libio/vasprintf.c (_IO_vasprintf, __vasprintf): Similarly.
+	* libio/obprintf.c (_IO_obstack_vprintf, __obstack_vprintf): Similarly.
+	(__obstack_printf): Use __obstack_printf_internal.
+	* libio/vsnprintf.c (_IO_vsnprintf, ___vsnprintf): Similarly, with
+	public aliases __vsnprintf and vsnprintf.
+	Remove use of ldbl_hidden_def, since __vsnprintf is no longer
+	called internally.
+	* libio/vswprintf (_IO_vswprintf, __vswprintf): Similarly, with
+	public aliases _IO_vsprintf and vsprintf.
+	* libio/swprintf.c (__swprintf): Use __vswprintf_internal.
+	* stdio-common/asprintf.c (__asprintf): Use __vasprintf_internal.
+	* stdio-common/dprintf.c (__dprintf): Use __vdprintf_internal.
+	* stdio-common/snprintf.c (__snprintf): Use __vsprintf_internal.
+	* stdio-common/sprintf.c (__sprintf): Use __vsprintf_internal.
+
+	* debug/obprintf_chk.c, debug/vasprintf_chk.c, debug/vdprintf_chk.c
+	* debug/vsnprintf_chk.c, debug/vsprintf_chk.c, hurd/vpprintf.c
+	* stdio-common/fprintf.c, stdio-common/fxprintf.c
+	* stdio-common/printf.c: Use __vfprintf_internal.
+
+	* debug/fwprintf_chk.c, debug/vfwprintf_chk.c, debug/vswprintf_chk.c
+	* debug/vwprintf_chk.c, debug/wprintf_chk.c, libio/fwprintf.c
+	* libio/vwprintf.c, libio/wprintf.c: Use __vfwprintf_internal.
+
+	* sysdeps/ieee754/ldbl-opt/nldbl-compat.c: Use __vsprintf_internal,
+	__obstack_vprintf_internal, __vasprintf_internal, __vdprintf_internal,
+	__vsnprintf_internal, __vswprintf_internal, __vfprintf_internal, and
+	__vfwprintf_internal.
+
+	* libio/libio.h: Remove libc_hidden_proto and declaration for
+	_IO_vfprintf.
+	Remove declaration of _IO_vfwprintf.
+	* libio/iolibio.h: Remove libc_hidden_proto and declaration for
+	_IO_vsprintf.
+	Remove declarations of _IO_vswprintf, _IO_obstack_printf, and
+	_IO_obstack_printf.
+	* include/stdio.h: Add prototype for __vasprintf.
+	(__vsnprintf): Remove declaration, because there are no more
+	internal calls.
+	* include/wchar.h (__vfwprintf, __vswprintf): Remove
+	declaration, because there are no more internal calls.
+
+	* argp/argp-fmtstream.c (__argp_fmtstream_printf): Use
+	__vsnprintf_internal, instead of _IO_vsnprintf.
+	* argp/argp-help.c (__argp_error, __argp_failure): Use
+	__vasprintf_internal, instead of _IO_vasprintf.
+	* argp/argp-namefrob.h (__vsnprintf): Do not undefined then
+	redefine, because there are no more internal calls.
+
+2018-12-05  Zack Weinberg  <zackw@panix.com>
+	    Gabriel F. T. Gomes  <gabriel@inconstante.eti.br>
+
 	* stdio-common/vfscanf-internal.c: Don't look at __ldbl_is_dbl.
 	* sysdeps/ieee754/ldbl-opt/ndlbl-compat.c:
 	Include libio/strfile.h instead of libioP.h.
diff --git a/argp/argp-fmtstream.c b/argp/argp-fmtstream.c
index e9e4c0e5cc..a5a5258684 100644
--- a/argp/argp-fmtstream.c
+++ b/argp/argp-fmtstream.c
@@ -42,7 +42,6 @@
 #ifdef _LIBC
 # include <wchar.h>
 # include <libio/libioP.h>
-# define __vsnprintf(s, l, f, a) _IO_vsnprintf (s, l, f, a)
 #endif
 
 #define INIT_BUF_SIZE 200
@@ -413,7 +412,7 @@ __argp_fmtstream_printf (struct argp_fmtstream *fs, const char *fmt, ...)
 
       va_start (args, fmt);
       avail = fs->end - fs->p;
-      out = __vsnprintf (fs->p, avail, fmt, args);
+      out = __vsnprintf_internal (fs->p, avail, fmt, args, 0);
       va_end (args);
       if ((size_t) out >= avail)
 	size_guess = out + 1;
diff --git a/argp/argp-help.c b/argp/argp-help.c
index a17260378c..09c76734d3 100644
--- a/argp/argp-help.c
+++ b/argp/argp-help.c
@@ -1769,7 +1769,7 @@ __argp_error (const struct argp_state *state, const char *fmt, ...)
 #ifdef _LIBC
 	  char *buf;
 
-	  if (_IO_vasprintf (&buf, fmt, ap) < 0)
+	  if (__vasprintf_internal (&buf, fmt, ap, 0) < 0)
 	    buf = NULL;
 
 	  __fxprintf (stream, "%s: %s\n",
@@ -1839,7 +1839,7 @@ __argp_failure (const struct argp_state *state, int status, int errnum,
 #ifdef _LIBC
 	      char *buf;
 
-	      if (_IO_vasprintf (&buf, fmt, ap) < 0)
+	      if (__vasprintf_internal (&buf, fmt, ap, 0) < 0)
 		buf = NULL;
 
 	      __fxprintf (stream, ": %s", buf);
diff --git a/argp/argp-namefrob.h b/argp/argp-namefrob.h
index 5588fe172a..5e48b5940d 100644
--- a/argp/argp-namefrob.h
+++ b/argp/argp-namefrob.h
@@ -98,8 +98,6 @@
 #define __strerror_r strerror_r
 #undef __strndup
 #define __strndup strndup
-#undef __vsnprintf
-#define __vsnprintf vsnprintf
 
 #if defined(HAVE_DECL_CLEARERR_UNLOCKED) && !HAVE_DECL_CLEARERR_UNLOCKED
 # define clearerr_unlocked(x) clearerr (x)
diff --git a/debug/fwprintf_chk.c b/debug/fwprintf_chk.c
index aeb83077da..63167c1839 100644
--- a/debug/fwprintf_chk.c
+++ b/debug/fwprintf_chk.c
@@ -32,7 +32,7 @@ __fwprintf_chk (FILE *fp, int flag, const wchar_t *format, ...)
     fp->_flags2 |= _IO_FLAGS2_FORTIFY;
 
   va_start (ap, format);
-  done = _IO_vfwprintf (fp, format, ap);
+  done = __vfwprintf_internal (fp, format, ap, 0);
   va_end (ap);
 
   if (flag > 0)
diff --git a/debug/obprintf_chk.c b/debug/obprintf_chk.c
index 3ac5a3cd4f..41dd481c34 100644
--- a/debug/obprintf_chk.c
+++ b/debug/obprintf_chk.c
@@ -91,7 +91,7 @@ __obstack_vprintf_chk (struct obstack *obstack, int flags, const char *format,
   if (flags > 0)
     new_f.ofile.file.file._flags2 |= _IO_FLAGS2_FORTIFY;
 
-  result = _IO_vfprintf (&new_f.ofile.file.file, format, args);
+  result = __vfprintf_internal (&new_f.ofile.file.file, format, args, 0);
 
   /* Shrink the buffer to the space we really currently need.  */
   obstack_blank_fast (obstack, (new_f.ofile.file.file._IO_write_ptr
diff --git a/debug/vasprintf_chk.c b/debug/vasprintf_chk.c
index 48b4741651..dbfebff83f 100644
--- a/debug/vasprintf_chk.c
+++ b/debug/vasprintf_chk.c
@@ -63,7 +63,7 @@ __vasprintf_chk (char **result_ptr, int flags, const char *format,
   if (flags > 0)
     sf._sbf._f._flags2 |= _IO_FLAGS2_FORTIFY;
 
-  ret = _IO_vfprintf (&sf._sbf._f, format, args);
+  ret = __vfprintf_internal (&sf._sbf._f, format, args, 0);
   if (ret < 0)
     {
       free (sf._sbf._f._IO_buf_base);
diff --git a/debug/vdprintf_chk.c b/debug/vdprintf_chk.c
index bc713b4962..4386127cfe 100644
--- a/debug/vdprintf_chk.c
+++ b/debug/vdprintf_chk.c
@@ -55,7 +55,7 @@ __vdprintf_chk (int d, int flags, const char *format, va_list arg)
   if (flags > 0)
     tmpfil.file._flags2 |= _IO_FLAGS2_FORTIFY;
 
-  done = _IO_vfprintf (&tmpfil.file, format, arg);
+  done = __vfprintf_internal (&tmpfil.file, format, arg, 0);
 
   _IO_FINISH (&tmpfil.file);
 
diff --git a/debug/vfwprintf_chk.c b/debug/vfwprintf_chk.c
index 1ffd18cbd2..abf2bd6517 100644
--- a/debug/vfwprintf_chk.c
+++ b/debug/vfwprintf_chk.c
@@ -30,7 +30,7 @@ __vfwprintf_chk (FILE *fp, int flag, const wchar_t *format, va_list ap)
   if (flag > 0)
     fp->_flags2 |= _IO_FLAGS2_FORTIFY;
 
-  done = _IO_vfwprintf (fp, format, ap);
+  done = __vfwprintf_internal (fp, format, ap, 0);
 
   if (flag > 0)
     fp->_flags2 &= ~_IO_FLAGS2_FORTIFY;
diff --git a/debug/vsnprintf_chk.c b/debug/vsnprintf_chk.c
index d20d0fbd93..95d286f416 100644
--- a/debug/vsnprintf_chk.c
+++ b/debug/vsnprintf_chk.c
@@ -60,7 +60,7 @@ ___vsnprintf_chk (char *s, size_t maxlen, int flags, size_t slen,
     sf.f._sbf._f._flags2 |= _IO_FLAGS2_FORTIFY;
 
   _IO_str_init_static_internal (&sf.f, s, maxlen - 1, s);
-  ret = _IO_vfprintf (&sf.f._sbf._f, format, args);
+  ret = __vfprintf_internal (&sf.f._sbf._f, format, args, 0);
 
   if (sf.f._sbf._f._IO_buf_base != sf.overflow_buf)
     *sf.f._sbf._f._IO_write_ptr = '\0';
diff --git a/debug/vsprintf_chk.c b/debug/vsprintf_chk.c
index 9a443bb699..53f07236ae 100644
--- a/debug/vsprintf_chk.c
+++ b/debug/vsprintf_chk.c
@@ -80,7 +80,7 @@ ___vsprintf_chk (char *s, int flags, size_t slen, const char *format,
   if (flags > 0)
     f._sbf._f._flags2 |= _IO_FLAGS2_FORTIFY;
 
-  ret = _IO_vfprintf (&f._sbf._f, format, args);
+  ret = __vfprintf_internal (&f._sbf._f, format, args, 0);
 
   *f._sbf._f._IO_write_ptr = '\0';
   return ret;
diff --git a/debug/vswprintf_chk.c b/debug/vswprintf_chk.c
index c6a7edcacd..4d616f8835 100644
--- a/debug/vswprintf_chk.c
+++ b/debug/vswprintf_chk.c
@@ -59,7 +59,7 @@ __vswprintf_chk (wchar_t *s, size_t maxlen, int flags, size_t slen,
     sf.f._sbf._f._flags2 |= _IO_FLAGS2_FORTIFY;
 
   _IO_wstr_init_static (&sf.f._sbf._f, s, maxlen - 1, s);
-  ret = _IO_vfwprintf ((FILE *) &sf.f._sbf, format, args);
+  ret = __vfwprintf_internal ((FILE *) &sf.f._sbf, format, args, 0);
 
   if (sf.f._sbf._f._wide_data->_IO_buf_base == sf.overflow_buf)
     /* ISO C99 requires swprintf/vswprintf to return an error if the
diff --git a/debug/vwprintf_chk.c b/debug/vwprintf_chk.c
index 51b67c159d..fedc7a46bf 100644
--- a/debug/vwprintf_chk.c
+++ b/debug/vwprintf_chk.c
@@ -31,7 +31,7 @@ __vwprintf_chk (int flag, const wchar_t *format, va_list ap)
   if (flag > 0)
     stdout->_flags2 |= _IO_FLAGS2_FORTIFY;
 
-  done = _IO_vfwprintf (stdout, format, ap);
+  done = __vfwprintf_internal (stdout, format, ap, 0);
 
   if (flag > 0)
     stdout->_flags2 &= ~_IO_FLAGS2_FORTIFY;
diff --git a/debug/wprintf_chk.c b/debug/wprintf_chk.c
index 17023b6bb4..819050e5af 100644
--- a/debug/wprintf_chk.c
+++ b/debug/wprintf_chk.c
@@ -33,7 +33,7 @@ __wprintf_chk (int flag, const wchar_t *format, ...)
     stdout->_flags2 |= _IO_FLAGS2_FORTIFY;