aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>2024-10-20 14:52:49 -0300
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>2024-11-01 11:27:39 -0300
commit8ae9e513762b1a67bac854871fc02988feb22efb (patch)
tree771a2565821e9313bf9ea58478933ee9a5c48749
parentc3695808141ff1655da8da3c4e9330bcd2305f55 (diff)
downloadglibc-8ae9e513762b1a67bac854871fc02988feb22efb.tar.xz
glibc-8ae9e513762b1a67bac854871fc02988feb22efb.zip
math: Use log1pf from CORE-MATH
The CORE-MATH implementation is correctly rounded (for any rounding mode) and shows slight better performance to the generic log1pf. The code was adapted to glibc style and to use the definition of math_config.h (to handle errno, overflow, and underflow). Benchtest on x64_64 (Ryzen 9 5900X, gcc 14.2.1), aarch64 (M1, gcc 13.2.1), and powerpc (POWER10, gcc 13.2.1): Latency master patched improvement x86_64 71.8142 38.9668 45.74% x86_64v2 71.9094 39.1321 45.58% x86_64v3 60.1000 32.4016 46.09% i686 147.105 104.258 29.13% aarch64 26.4439 14.0050 47.04% power10 19.4874 9.4146 51.69% powerpc 17.6145 8.00736 54.54% reciprocal-throughput master patched improvement x86_64 19.7604 12.7254 35.60% x86_64v2 19.0039 11.9455 37.14% x86_64v3 16.8559 11.9317 29.21% i686 82.3426 73.9718 10.17% aarch64 14.4665 7.9614 44.97% power10 11.9974 8.4117 29.89% powerpc 7.15222 6.0914 14.83% Signed-off-by: Alexei Sibidanov <sibid@uvic.ca> Signed-off-by: Paul Zimmermann <Paul.Zimmermann@inria.fr> Signed-off-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> Reviewed-by: DJ Delorie <dj@redhat.com>
-rw-r--r--SHARED-FILES4
-rw-r--r--sysdeps/aarch64/libm-test-ulps8
-rw-r--r--sysdeps/alpha/fpu/libm-test-ulps8
-rw-r--r--sysdeps/arc/fpu/libm-test-ulps8
-rw-r--r--sysdeps/arc/nofpu/libm-test-ulps1
-rw-r--r--sysdeps/arm/libm-test-ulps8
-rw-r--r--sysdeps/csky/fpu/libm-test-ulps8
-rw-r--r--sysdeps/csky/nofpu/libm-test-ulps8
-rw-r--r--sysdeps/hppa/fpu/libm-test-ulps8
-rw-r--r--sysdeps/i386/fpu/libm-test-ulps6
-rw-r--r--sysdeps/i386/fpu/s_log1pf.S66
-rw-r--r--sysdeps/i386/i686/fpu/multiarch/libm-test-ulps6
-rw-r--r--sysdeps/ieee754/flt-32/s_log1pf.c271
-rw-r--r--sysdeps/ieee754/flt-32/w_log1pf.c1
-rw-r--r--sysdeps/loongarch/lp64/libm-test-ulps8
-rw-r--r--sysdeps/m68k/coldfire/fpu/libm-test-ulps6
-rw-r--r--sysdeps/m68k/m680x0/fpu/w_log1pf.c20
-rw-r--r--sysdeps/microblaze/libm-test-ulps2
-rw-r--r--sysdeps/mips/mips32/libm-test-ulps8
-rw-r--r--sysdeps/mips/mips64/libm-test-ulps8
-rw-r--r--sysdeps/nios2/libm-test-ulps2
-rw-r--r--sysdeps/or1k/nofpu/libm-test-ulps8
-rw-r--r--sysdeps/powerpc/fpu/libm-test-ulps8
-rw-r--r--sysdeps/powerpc/nofpu/libm-test-ulps8
-rw-r--r--sysdeps/riscv/nofpu/libm-test-ulps8
-rw-r--r--sysdeps/riscv/rvd/libm-test-ulps8
-rw-r--r--sysdeps/s390/fpu/libm-test-ulps8
-rw-r--r--sysdeps/sh/libm-test-ulps4
-rw-r--r--sysdeps/sparc/fpu/libm-test-ulps8
-rw-r--r--sysdeps/x86_64/fpu/libm-test-ulps8
30 files changed, 193 insertions, 340 deletions
diff --git a/SHARED-FILES b/SHARED-FILES
index 58ea318ccc..7fa54a5c9d 100644
--- a/SHARED-FILES
+++ b/SHARED-FILES
@@ -260,3 +260,7 @@ sysdeps/ieee754/flt-32/s_log2p1f.c
(file src/binary32/log2p1/log2p1f.c in CORE-MATH)
- The code was adapted to use glibc code style and internal
functions to handle errno, overflow, and underflow.
+sysdeps/ieee754/flt-32/s_log1pf.c
+ (file src/binary32/log1p/log1pf.c in CORE-MATH)
+ - The code was adapted to use glibc code style and internal
+ functions to handle errno, overflow, and underflow.
diff --git a/sysdeps/aarch64/libm-test-ulps b/sysdeps/aarch64/libm-test-ulps
index cb1c18cb50..5700c712ff 100644
--- a/sysdeps/aarch64/libm-test-ulps
+++ b/sysdeps/aarch64/libm-test-ulps
@@ -1366,7 +1366,6 @@ ldouble: 4
Function: "log1p":
double: 1
-float: 1
ldouble: 3
Function: "log1p_advsimd":
@@ -1375,7 +1374,6 @@ float: 1
Function: "log1p_downward":
double: 1
-float: 2
ldouble: 3
Function: "log1p_sve":
@@ -1384,12 +1382,10 @@ float: 1
Function: "log1p_towardzero":
double: 2
-float: 2
ldouble: 3
Function: "log1p_upward":
double: 2
-float: 2
ldouble: 2
Function: "log2":
@@ -1459,22 +1455,18 @@ ldouble: 1
Function: "logp1":
double: 1
-float: 1
ldouble: 3
Function: "logp1_downward":
double: 1
-float: 2
ldouble: 3
Function: "logp1_towardzero":
double: 2
-float: 2
ldouble: 3
Function: "logp1_upward":
double: 2
-float: 2
ldouble: 2
Function: "pow":
diff --git a/sysdeps/alpha/fpu/libm-test-ulps b/sysdeps/alpha/fpu/libm-test-ulps
index 09185dd902..212c52c8cc 100644
--- a/sysdeps/alpha/fpu/libm-test-ulps
+++ b/sysdeps/alpha/fpu/libm-test-ulps
@@ -1202,22 +1202,18 @@ ldouble: 3
Function: "log1p":
double: 1
-float: 1
ldouble: 3
Function: "log1p_downward":
double: 2
-float: 2
ldouble: 3
Function: "log1p_towardzero":
double: 2
-float: 2
ldouble: 3
Function: "log1p_upward":
double: 2
-float: 2
ldouble: 2
Function: "log2":
@@ -1267,22 +1263,18 @@ ldouble: 1
Function: "logp1":
double: 1
-float: 1
ldouble: 3
Function: "logp1_downward":
double: 2
-float: 2
ldouble: 3
Function: "logp1_towardzero":
double: 2
-float: 2
ldouble: 3
Function: "logp1_upward":
double: 2
-float: 2
ldouble: 2
Function: "pow":
diff --git a/sysdeps/arc/fpu/libm-test-ulps b/sysdeps/arc/fpu/libm-test-ulps
index d2ec67b504..f73aae2833 100644
--- a/sysdeps/arc/fpu/libm-test-ulps
+++ b/sysdeps/arc/fpu/libm-test-ulps
@@ -981,19 +981,15 @@ float: 3
Function: "log1p":
double: 1
-float: 1
Function: "log1p_downward":
double: 1
-float: 2
Function: "log1p_towardzero":
double: 2
-float: 2
Function: "log1p_upward":
double: 2
-float: 2
Function: "log2":
double: 2
@@ -1029,19 +1025,15 @@ float: 1
Function: "logp1":
double: 1
-float: 1
Function: "logp1_downward":
double: 1
-float: 2
Function: "logp1_towardzero":
double: 2
-float: 2
Function: "logp1_upward":
double: 2
-float: 2
Function: "pow":
double: 1
diff --git a/sysdeps/arc/nofpu/libm-test-ulps b/sysdeps/arc/nofpu/libm-test-ulps
index fe74fb8ea9..f6d1ef062c 100644
--- a/sysdeps/arc/nofpu/libm-test-ulps
+++ b/sysdeps/arc/nofpu/libm-test-ulps
@@ -238,7 +238,6 @@ float: 2
Function: "log1p":
double: 1
-float: 1
Function: "log2":
double: 2
diff --git a/sysdeps/arm/libm-test-ulps b/sysdeps/arm/libm-test-ulps
index b6b194143a..502680ff1b 100644
--- a/sysdeps/arm/libm-test-ulps
+++ b/sysdeps/arm/libm-test-ulps
@@ -974,19 +974,15 @@ float: 3
Function: "log1p":
double: 1
-float: 1
Function: "log1p_downward":
double: 2
-float: 2
Function: "log1p_towardzero":
double: 2
-float: 2
Function: "log1p_upward":
double: 2
-float: 2
Function: "log2":
double: 2
@@ -1028,19 +1024,15 @@ float: 2
Function: "logp1":
double: 1
-float: 1
Function: "logp1_downward":
double: 2
-float: 2
Function: "logp1_towardzero":
double: 2
-float: 2
Function: "logp1_upward":
double: 2
-float: 2
Function: "pow":
double: 1
diff --git a/sysdeps/csky/fpu/libm-test-ulps b/sysdeps/csky/fpu/libm-test-ulps
index 3f17778d03..a7b2bec17e 100644
--- a/sysdeps/csky/fpu/libm-test-ulps
+++ b/sysdeps/csky/fpu/libm-test-ulps
@@ -919,19 +919,15 @@ float: 2
Function: "log1p":
double: 1
-float: 1
Function: "log1p_downward":
double: 2
-float: 2
Function: "log1p_towardzero":
double: 2
-float: 2
Function: "log1p_upward":
double: 2
-float: 2
Function: "log2":
double: 2
@@ -948,19 +944,15 @@ double: 3
Function: "logp1":
double: 1
-float: 1
Function: "logp1_downward":
double: 2
-float: 2
Function: "logp1_towardzero":
double: 2
-float: 2
Function: "logp1_upward":
double: 2
-float: 2
Function: "pow":
double: 1
diff --git a/sysdeps/csky/nofpu/libm-test-ulps b/sysdeps/csky/nofpu/libm-test-ulps
index fdef935578..4e4451a5d2 100644
--- a/sysdeps/csky/nofpu/libm-test-ulps
+++ b/sysdeps/csky/nofpu/libm-test-ulps
@@ -920,19 +920,15 @@ float: 2
Function: "log1p":
double: 1
-float: 1
Function: "log1p_downward":
double: 2
-float: 2
Function: "log1p_towardzero":
double: 2
-float: 2
Function: "log1p_upward":
double: 2
-float: 2
Function: "log2":
double: 2
@@ -962,19 +958,15 @@ float: 2
Function: "logp1":
double: 1
-float: 1
Function: "logp1_downward":
double: 2
-float: 2
Function: "logp1_towardzero":
double: 2
-float: 2
Function: "logp1_upward":
double: 2
-float: 2
Function: "pow":
double: 1
diff --git a/sysdeps/hppa/fpu/libm-test-ulps b/sysdeps/hppa/fpu/libm-test-ulps
index 9f89528947..b56f512b39 100644
--- a/sysdeps/hppa/fpu/libm-test-ulps
+++ b/sysdeps/hppa/fpu/libm-test-ulps
@@ -997,19 +997,15 @@ float: 3
Function: "log1p":
double: 1
-float: 1
Function: "log1p_downward":
double: 2
-float: 2
Function: "log1p_towardzero":
double: 2
-float: 2
Function: "log1p_upward":
double: 2
-float: 2
Function: "log2":
double: 2
@@ -1051,19 +1047,15 @@ float: 2
Function: "logp1":
double: 1
-float: 1
Function: "logp1_downward":
double: 2
-float: 2
Function: "logp1_towardzero":
double: 2
-float: 2
Function: "logp1_upward":
double: 2
-float: 2
Function: "pow":
double: 1
diff --git a/sysdeps/i386/fpu/libm-test-ulps b/sysdeps/i386/fpu/libm-test-ulps
index d0bd63371d..63ef3569b4 100644
--- a/sysdeps/i386/fpu/libm-test-ulps
+++ b/sysdeps/i386/fpu/libm-test-ulps
@@ -1443,19 +1443,16 @@ ldouble: 2
Function: "log1p_downward":
double: 1
-float: 1
float128: 3
ldouble: 4
Function: "log1p_towardzero":
double: 1
-float: 1
float128: 3
ldouble: 4
Function: "log1p_upward":
double: 1
-float: 1
float128: 2
ldouble: 3
@@ -1524,19 +1521,16 @@ ldouble: 2
Function: "logp1_downward":
double: 1
-float: 1
float128: 3
ldouble: 4
Function: "logp1_towardzero":
double: 1
-float: 1
float128: 3
ldouble: 4
Function: "logp1_upward":
double: 1
-float: 1
float128: 2
ldouble: 3
diff --git a/sysdeps/i386/fpu/s_log1pf.S b/sysdeps/i386/fpu/s_log1pf.S
deleted file mode 100644
index 82a3f448db..0000000000
--- a/sysdeps/i386/fpu/s_log1pf.S
+++ /dev/null
@@ -1,66 +0,0 @@
-/*
- * Public domain.
- */
-
-#include <machine/asm.h>
-#include <i386-math-asm.h>
-
-RCSID("$NetBSD: s_log1pf.S,v 1.4 1995/05/09 00:13:05 jtc Exp $")
-
- .section .rodata
-
- .align ALIGNARG(4)
- /* The fyl2xp1 can only be used for values in
- -1 + sqrt(2) / 2 <= x <= 1 - sqrt(2) / 2
- 0.29 is a safe value.
- */
-limit: .float 0.29
-one: .float 1.0
-
-DEFINE_FLT_MIN
-
-#ifdef PIC
-# define MO(op) op##@GOTOFF(%edx)
-#else
-# define MO(op) op
-#endif
-
-/*
- * Use the fyl2xp1 function when the argument is in the range -0.29 to 0.29,
- * otherwise fyl2x with the needed extra computation.
- */
- .text
-ENTRY(__log1pf)
- fldln2
-
- flds 4(%esp)
-
-#ifdef PIC
- LOAD_PIC_REG (dx)
-#endif
-
- fxam
- fnstsw
- fld %st
- sahf
- jc 3f // in case x is NaN or ħInf
-4: fabs
- fcomps MO(limit)
- fnstsw
- sahf
- jc 2f
-
- fadds MO(one)
- fyl2x
- ret
-
-2: fyl2xp1
- FLT_CHECK_FORCE_UFLOW_NONNAN
- ret
-
-3: jp 4b // in case x is ħInf
- fstp %st(1)
- fstp %st(1)
- ret
-
-END (__log1pf)
diff --git a/sysdeps/i386/i686/fpu/multiarch/libm-test-ulps b/sysdeps/i386/i686/fpu/multiarch/libm-test-ulps
index a97722b7e7..f6393dbdf1 100644
--- a/sysdeps/i386/i686/fpu/multiarch/libm-test-ulps
+++ b/sysdeps/i386/i686/fpu/multiarch/libm-test-ulps
@@ -1446,19 +1446,16 @@ ldouble: 2
Function: "log1p_downward":
double: 1
-float: 1
float128: 3
ldouble: 4
Function: "log1p_towardzero":
double: 1
-float: 1
float128: 3
ldouble: 4
Function: "log1p_upward":
double: 1
-float: 1
float128: 2
ldouble: 3
@@ -1527,19 +1524,16 @@ ldouble: 2
Function: "logp1_downward":
double: 1
-float: 1
float128: 3
ldouble: 4
Function: "logp1_towardzero":
double: 1
-float: 1
float128: 3
ldouble: 4
Function: "logp1_upward":
double: 1
-float: 1
float128: 2
ldouble: 3
diff --git a/sysdeps/ieee754/flt-32/s_log1pf.c b/sysdeps/ieee754/flt-32/s_log1pf.c
index 555f0f82c8..d1686e78aa 100644
--- a/sysdeps/ieee754/flt-32/s_log1pf.c
+++ b/sysdeps/ieee754/flt-32/s_log1pf.c
@@ -1,116 +1,181 @@
-/* s_log1pf.c -- float version of s_log1p.c.
- */
+/* Correctly-rounded biased argument natural logarithm function for binary32
+ value.
-/*
- * ====================================================
- * Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved.
- *
- * Developed at SunPro, a Sun Microsystems, Inc. business.
- * Permission to use, copy, modify, and distribute this
- * software is freely granted, provided that this notice
- * is preserved.
- * ====================================================
- */
+Copyright (c) 2023, 2024 Alexei Sibidanov.
-#include <float.h>
-#include <math.h>
-#include <math-barriers.h>
-#include <math_private.h>
-#include <math-underflow.h>
-#include <libc-diag.h>
+This file is part of the CORE-MATH project
+project (file src/binary32/log1p/log1pf.c revision bc385c2).
-static const float
-ln2_hi = 6.9313812256e-01, /* 0x3f317180 */
-ln2_lo = 9.0580006145e-06, /* 0x3717f7d1 */
-two25 = 3.355443200e+07, /* 0x4c000000 */
-Lp1 = 6.6666668653e-01, /* 3F2AAAAB */
-Lp2 = 4.0000000596e-01, /* 3ECCCCCD */
-Lp3 = 2.8571429849e-01, /* 3E924925 */
-Lp4 = 2.2222198546e-01, /* 3E638E29 */
-Lp5 = 1.8183572590e-01, /* 3E3A3325 */
-Lp6 = 1.5313838422e-01, /* 3E1CD04F */
-Lp7 = 1.4798198640e-01; /* 3E178897 */
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
-static const float zero = 0.0;
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
-float
-__log1pf(float x)
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABIL