diff options
| author | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2016-12-02 16:32:28 -0200 |
|---|---|---|
| committer | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2017-06-23 17:38:17 -0300 |
| commit | fa872e1b6210e81e60d6029429f0a083b8eab26e (patch) | |
| tree | 658bfebcc8b71d0def38f50210f75fc4eba055fa | |
| parent | 06a5b8f7994c241dccfaebd5c08c3e06a2dedb8f (diff) | |
| download | glibc-fa872e1b6210e81e60d6029429f0a083b8eab26e.tar.xz glibc-fa872e1b6210e81e60d6029429f0a083b8eab26e.zip | |
Clean pthread functions namespaces for C11 threads
This patch adds internal definition (through {libc_}hidden_{proto,def}) and
also change some strong to weak alias for symbols that might be used by C11
threads implementations.
The patchset should not change libc/libpthread functional, although object
changes are expected (since now internal symbols are used instead) and final
exported symbols through GLIBC_PRIVATE is also expanded (to cover libpthread
usage of __mmap{64}, __munmap, __mprotect).
Checked with a build for all major ABI (aarch64-linux-gnu, alpha-linux-gnu,
arm-linux-gnueabi, i386-linux-gnu, ia64-linux-gnu, m68k-linux-gnu,
microblaze-linux-gnu [1], mips{64}-linux-gnu, nios2-linux-gnu,
powerpc{64le}-linux-gnu, s390{x}-linux-gnu, sparc{64}-linux-gnu,
tile{pro,gx}-linux-gnu, and x86_64-linux-gnu).
* include/sched.h (__sched_get_priority_max): Add libc hidden proto.
(__sched_get_prioriry_min): Likewise.
* include/sys/mman.h (__mmap): Likewise.
(__mmap64): Likewise.
(__munmap): Likewise.
(__mprotect): Likewise.
* include/termios.h (__tcsetattr): Likewise.
* include/time.h (__nanosleep): Use hidden_proto instead of
libc_hidden_proto.
* posix/nanosleep.c (__nanosleep): Likewise.
* misc/Versions (libc): Export __mmap, __munmap, __mprotect,
__sched_get_priority_min, and __sched_get_priority_max under
GLIBC_PRIVATE.
* nptl/allocatestack.c (__free_stacks): Use internal definition for
libc symbols.
(change_stack_perm): Likewise.
(allocate_stack): Likewise.
* sysdeps/posix/gethostname.c: Likewise.
* nptl/tpp.c (__init_sched_fifo_prio): Likewise.
* sysdeps/unix/sysv/linux/i386/smp.h (is_smp_system): Likewise.
* sysdeps/unix/sysv/linux/powerpc/ioctl.c (__ioctl): Likewise.
* nptl/pthreadP.h (__pthread_mutex_timedlock): Add definition.
(__pthread_key_delete): Likewise.
(__pthread_detach): Likewise.
(__pthread_cancel): Likewise.
(__pthread_mutex_trylock): Likewise.
(__pthread_mutexattr_init): Likewise.
(__pthread_mutexattr_settype): Likewise.
* nptl/pthread_cancel.c (pthread_cancel): Change to internal name and
create alias for exported one.
* nptl/pthread_join.c (pthread_join): Likewise.
* nptl/pthread_detach.c (pthread_detach): Likewise.
* nptl/pthread_key_delete.c (pthread_key_delete): Likewise.
* nptl/pthread_mutex_timedlock.c (pthread_mutex_timedlock): Likewise.
* nptl/pthread_create.c: Change static requirements for pthread
symbols.
* nptl/pthread_equal.c (__pthread_equal): Change strong alias to weak
for internal definition.
* nptl/pthread_exit.c (__pthread_exit): Likewise.
* nptl/pthread_getspecific.c (__pthread_getspecific): Likewise.
* nptl/pthread_key_create.c (__pthread_key_create): Likewise.
* nptl/pthread_mutex_destroy.c (__pthread_mutex_destroy): Likewise.
* nptl/pthread_mutex_init.c (__pthread_mutex_init): Likewise.
* nptl/pthread_mutex_lock.c (__pthread_mutex_lock): Likewise.
* nptl/pthread_mutex_trylock.c (__pthread_mutex_trylock): Likewise.
* nptl/pthread_mutex_unlock.c (__pthread_mutex_unlock): Likewise.
* nptl/pthread_mutexattr_init.c (__pthread_mutexattr_init): Likwise.
* nptl/pthread_mutexattr_settype.c (__pthread_mutexattr_settype):
Likewise.
* nptl/pthread_self.c (__pthread_self): Likewise.
* nptl/pthread_setspecific.c (__pthread_setspecific): Likewise.
* sysdeps/unix/sysv/linux/tcsetattr.c (tcsetattr): Likewise.
* misc/mmap.c (__mmap): Add internal symbol definition.
* misc/mmap.c (__mmap64): Likewise.
* sysdeps/unix/sysv/linux/mmap.c (__mmap): Likewise.
* sysdeps/unix/sysv/linux/mmap64.c (__mmap): Likewise.
(__mmap64): Likewise.
* sysdeps/unix/sysv/linux/i386/Versions (libc) [GLIBC_PRIVATE):
Add __uname.
39 files changed, 156 insertions, 59 deletions
@@ -1,3 +1,67 @@ +2017-05-23 Adhemerval Zanella <adhemerval.zanella@linaro.org> + Juan Manuel Torres Palma <jmtorrespalma@gmail.com> + + * include/sched.h (__sched_get_priority_max): Add libc hidden proto. + (__sched_get_prioriry_min): Likewise. + * include/sys/mman.h (__mmap): Likewise. + (__mmap64): Likewise. + (__munmap): Likewise. + (__mprotect): Likewise. + * include/termios.h (__tcsetattr): Likewise. + * include/time.h (__nanosleep): Use hidden_proto instead of + libc_hidden_proto. + * posix/nanosleep.c (__nanosleep): Likewise. + * misc/Versions (libc): Export __mmap, __munmap, __mprotect, + __sched_get_priority_min, and __sched_get_priority_max under + GLIBC_PRIVATE. + * nptl/allocatestack.c (__free_stacks): Use internal definition for + libc symbols. + (change_stack_perm): Likewise. + (change_stack_perm): Likewise. + (allocate_stack): Likewise. + * sysdeps/posix/gethostname.c: Likewise. + * nptl/tpp.c (__init_sched_fifo_prio): Likewise. + * sysdeps/unix/sysv/linux/i386/smp.h (is_smp_system): Likewise. + * sysdeps/unix/sysv/linux/powerpc/ioctl.c (__ioctl): Likewise. + * nptl/pthreadP.h (__pthread_mutex_timedlock): Add definition. + (__pthread_key_delete): Likewise. + (__pthread_detach): Likewise. + (__pthread_cancel): Likewise. + (__pthread_mutex_trylock): Likewise. + (__pthread_mutexattr_init): Likewise. + (__pthread_mutexattr_settype): Likewise. + * nptl/pthread_cancel.c (pthread_cancel): Change to internal name and + create alias for exported one. + * nptl/pthread_join.c (pthread_join): Likewise. + * nptl/pthread_detach.c (pthread_detach): Likewise. + * nptl/pthread_key_delete.c (pthread_key_delete): Likewise. + * nptl/pthread_mutex_timedlock.c (pthread_mutex_timedlock): Likewise. + * nptl/pthread_create.c: Change static requirements for pthread + symbols. + * nptl/pthread_equal.c (__pthread_equal): Change strong alias to weak + for internal definition. + * nptl/pthread_exit.c (__pthread_exit): Likewise. + * nptl/pthread_getspecific.c (__pthread_getspecific): Likewise. + * nptl/pthread_key_create.c (__pthread_key_create): Likewise. + * nptl/pthread_mutex_destroy.c (__pthread_mutex_destroy): Likewise. + * nptl/pthread_mutex_init.c (__pthread_mutex_init): Likewise. + * nptl/pthread_mutex_lock.c (__pthread_mutex_lock): Likewise. + * nptl/pthread_mutex_trylock.c (__pthread_mutex_trylock): Likewise. + * nptl/pthread_mutex_unlock.c (__pthread_mutex_unlock): Likewise. + * nptl/pthread_mutexattr_init.c (__pthread_mutexattr_init): Likwise. + * nptl/pthread_mutexattr_settype.c (__pthread_mutexattr_settype): + Likewise. + * nptl/pthread_self.c (__pthread_self): Likewise. + * nptl/pthread_setspecific.c (__pthread_setspecific): Likewise. + * sysdeps/unix/sysv/linux/tcsetattr.c (tcsetattr): Likewise. + * misc/mmap.c (__mmap): Add internal symbol definition. + * misc/mmap.c (__mmap64): Likewise. + * sysdeps/unix/sysv/linux/mmap.c (__mmap): Likewise. + * sysdeps/unix/sysv/linux/mmap64.c (__mmap): Likewise. + (__mmap64): Likewise. + * sysdeps/unix/sysv/linux/i386/Versions (libc) [GLIBC_PRIVATE): + Add __uname. + 2017-06-23 Joseph Myers <joseph@codesourcery.com> * sysdeps/i386/fpu/libm-test-ulps: Update. diff --git a/include/sched.h b/include/sched.h index b4d74064de..f75faed4ce 100644 --- a/include/sched.h +++ b/include/sched.h @@ -13,7 +13,9 @@ extern int __sched_getscheduler (__pid_t __pid); extern int __sched_yield (void); libc_hidden_proto (__sched_yield) extern int __sched_get_priority_max (int __algorithm); +libc_hidden_proto (__sched_get_priority_max) extern int __sched_get_priority_min (int __algorithm); +libc_hidden_proto (__sched_get_priority_min) extern int __sched_rr_get_interval (__pid_t __pid, struct timespec *__t); /* These are Linux specific. */ diff --git a/include/sys/mman.h b/include/sys/mman.h index 7026f69f42..8b996fce73 100644 --- a/include/sys/mman.h +++ b/include/sys/mman.h @@ -5,10 +5,14 @@ /* Now define the internal interfaces. */ extern void *__mmap (void *__addr, size_t __len, int __prot, int __flags, int __fd, __off_t __offset); +libc_hidden_proto (__mmap) extern void *__mmap64 (void *__addr, size_t __len, int __prot, int __flags, int __fd, __off64_t __offset); +libc_hidden_proto (__mmap64) extern int __munmap (void *__addr, size_t __len); +libc_hidden_proto (__munmap) extern int __mprotect (void *__addr, size_t __len, int __prot); +libc_hidden_proto (__mprotect) extern int __madvise (void *__addr, size_t __len, int __advice); libc_hidden_proto (__madvise) diff --git a/include/termios.h b/include/termios.h index fad51f8385..1a36e226b8 100644 --- a/include/termios.h +++ b/include/termios.h @@ -4,6 +4,8 @@ #ifndef _ISOMAC /* Now define the internal interfaces. */ extern int __tcgetattr (int __fd, struct termios *__termios_p); +extern int __tcsetattr (int __fd, int __optional_actions, + const struct termios *__termios_p); extern int __libc_tcdrain (int __fd); diff --git a/include/time.h b/include/time.h index 7eb0fa72d9..9956b82eb8 100644 --- a/include/time.h +++ b/include/time.h @@ -78,7 +78,7 @@ extern struct tm *__tz_convert (const time_t *timer, int use_localtime, struct t extern int __nanosleep (const struct timespec *__requested_time, struct timespec *__remaining); -libc_hidden_proto (__nanosleep) +hidden_proto (__nanosleep) extern int __nanosleep_nocancel (const struct timespec *__requested_time, struct timespec *__remaining) attribute_hidden; diff --git a/misc/Versions b/misc/Versions index bafda78a1f..bfbda505e4 100644 --- a/misc/Versions +++ b/misc/Versions @@ -163,5 +163,7 @@ libc { __mktemp; __libc_ifunc_impl_list; __tdelete; __tfind; __tsearch; __twalk; + __mmap; __munmap; __mprotect; + __sched_get_priority_min; __sched_get_priority_max; } } diff --git a/misc/mmap.c b/misc/mmap.c index 576d66a1e8..4172d76ef6 100644 --- a/misc/mmap.c +++ b/misc/mmap.c @@ -37,3 +37,4 @@ __mmap (__ptr_t addr, size_t len, int prot, int flags, int fd, off_t offset) stub_warning (mmap) weak_alias (__mmap, mmap) +libc_hidden_def (__mmap) diff --git a/misc/mmap64.c b/misc/mmap64.c index 6b1ac41c84..845b847587 100644 --- a/misc/mmap64.c +++ b/misc/mmap64.c @@ -45,3 +45,4 @@ __mmap64 (__ptr_t addr, size_t len, int prot, int flags, int fd, } weak_alias (__mmap64, mmap64) +libc_hidden_def (__mmap64) diff --git a/nptl/allocatestack.c b/nptl/allocatestack.c index 8364406b1b..ec7d42e027 100644 --- a/nptl/allocatestack.c +++ b/nptl/allocatestack.c @@ -278,7 +278,7 @@ __free_stacks (size_t limit) /* Remove this block. This should never fail. If it does something is really wrong. */ - if (munmap (curr->stackblock, curr->stackblock_size) != 0) + if (__munmap (curr->stackblock, curr->stackblock_size) != 0) abort (); /* Maybe we have freed enough. */ @@ -328,7 +328,7 @@ change_stack_perm (struct pthread *pd #else # error "Define either _STACK_GROWS_DOWN or _STACK_GROWS_UP" #endif - if (mprotect (stack, len, PROT_READ | PROT_WRITE | PROT_EXEC) != 0) + if (__mprotect (stack, len, PROT_READ | PROT_WRITE | PROT_EXEC) != 0) return errno; return 0; @@ -359,14 +359,14 @@ setup_stack_prot (char *mem, size_t size, char *guard, size_t guardsize, #if _STACK_GROWS_DOWN /* As defined at guard_position, for architectures with downward stack the guard page is always at start of the allocated area. */ - if (mprotect (guardend, size - guardsize, prot) != 0) + if (__mprotect (guardend, size - guardsize, prot) != 0) return errno; #else size_t mprots1 = (uintptr_t) guard - (uintptr_t) mem; - if (mprotect (mem, mprots1, prot) != 0) + if (__mprotect (mem, mprots1, prot) != 0) return errno; size_t mprots2 = ((uintptr_t) mem + size) - (uintptr_t) guardend; - if (mprotect (guardend, mprots2, prot) != 0) + if (__mprotect (guardend, mprots2, prot) != 0) return errno; #endif return 0; @@ -530,8 +530,8 @@ allocate_stack (const struct pthread_attr *attr, struct pthread **pdp, /* If a guard page is required, avoid committing memory by first allocate with PROT_NONE and then reserve with required permission excluding the guard page. */ - mem = mmap (NULL, size, (guardsize == 0) ? prot : PROT_NONE, - MAP_PRIVATE | MAP_ANONYMOUS | MAP_STACK, -1, 0); + mem = __mmap (NULL, size, (guardsize == 0) ? prot : PROT_NONE, + MAP_PRIVATE | MAP_ANONYMOUS | MAP_STACK, -1, 0); if (__glibc_unlikely (mem == MAP_FAILED)) return errno; @@ -557,7 +557,7 @@ allocate_stack (const struct pthread_attr *attr, struct pthread **pdp, pagesize_m1); if (setup_stack_prot (mem, size, guard, guardsize, prot) != 0) { - munmap (mem, size); + __munmap (mem, size); return errno; } } @@ -600,7 +600,7 @@ allocate_stack (const struct pthread_attr *attr, struct pthread **pdp, assert (errno == ENOMEM); /* Free the stack memory we just allocated. */ - (void) munmap (mem, size); + (void) __munmap (mem, size); return errno; } @@ -630,7 +630,7 @@ allocate_stack (const struct pthread_attr *attr, struct pthread **pdp, if (err != 0) { /* Free the stack memory we just allocated. */ - (void) munmap (mem, size); + (void) __munmap (mem, size); return err; } @@ -650,7 +650,7 @@ allocate_stack (const struct pthread_attr *attr, struct pthread **pdp, { char *guard = guard_position (mem, size, guardsize, pd, pagesize_m1); - if (mprotect (guard, guardsize, PROT_NONE) != 0) + if (__mprotect (guard, guardsize, PROT_NONE) != 0) { mprot_error: lll_lock (stack_cache_lock, LLL_PRIVATE); @@ -668,7 +668,7 @@ allocate_stack (const struct pthread_attr *attr, struct pthread **pdp, of memory caused problems we better do not use it anymore. Uh, and we ignore possible errors. There is nothing we could do. */ - (void) munmap (mem, size); + (void) __munmap (mem, size); return errno; } @@ -685,19 +685,19 @@ allocate_stack (const struct pthread_attr *attr, struct pthread **pdp, char *oldguard = mem + (((size - pd->guardsize) / 2) & ~pagesize_m1); if (oldguard < guard - && mprotect (oldguard, guard - oldguard, prot) != 0) + && __mprotect (oldguard, guard - oldguard, prot) != 0) goto mprot_error; - if (mprotect (guard + guardsize, + if (__mprotect (guard + guardsize, oldguard + pd->guardsize - guard - guardsize, prot) != 0) goto mprot_error; #elif _STACK_GROWS_DOWN - if (mprotect ((char *) mem + guardsize, pd->guardsize - guardsize, + if (__mprotect ((char *) mem + guardsize, pd->guardsize - guardsize, prot) != 0) goto mprot_error; #elif _STACK_GROWS_UP - if (mprotect ((char *) pd - pd->guardsize, + if (__mprotect ((char *) pd - pd->guardsize, pd->guardsize - guardsize, prot) != 0) goto mprot_error; #endif diff --git a/nptl/pthreadP.h b/nptl/pthreadP.h index 7fc1e50f78..6e7d6ff09e 100644 --- a/nptl/pthreadP.h +++ b/nptl/pthreadP.h @@ -428,6 +428,8 @@ extern int __pthread_mutex_init (pthread_mutex_t *__mutex, extern int __pthread_mutex_destroy (pthread_mutex_t *__mutex); extern int __pthread_mutex_trylock (pthread_mutex_t *_mutex); extern int __pthread_mutex_lock (pthread_mutex_t *__mutex); +extern int __pthread_mutex_timedlock (pthread_mutex_t *__mutex, + const struct timespec *__abstime); extern int __pthread_mutex_cond_lock (pthread_mutex_t *__mutex) attribute_hidden internal_function; extern void __pthread_mutex_cond_lock_adjust (pthread_mutex_t *__mutex) @@ -491,6 +493,7 @@ extern int __pthread_cond_timedwait (pthread_cond_t *cond, extern int __pthread_condattr_destroy (pthread_condattr_t *attr); extern int __pthread_condattr_init (pthread_condattr_t *attr); extern int __pthread_key_create (pthread_key_t *key, void (*destr) (void *)); +extern int __pthread_key_delete (pthread_key_t key); extern void *__pthread_getspecific (pthread_key_t key); extern int __pthread_setspecific (pthread_key_t key, const void *value); extern int __pthread_once (pthread_once_t *once_control, @@ -499,8 +502,11 @@ extern int __pthread_atfork (void (*prepare) (void), void (*parent) (void), void (*child) (void)); extern pthread_t __pthread_self (void);< |
