diff options
| author | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2016-01-29 11:43:40 -0200 |
|---|---|---|
| committer | Adhemerval Zanella <adhemerval.zanella@linaro.com> | 2016-03-07 00:21:36 -0300 |
| commit | f83bb9b8e97656ae0d3e2a31e859363e2d4d5832 (patch) | |
| tree | 3360c4505fee657945315275c1a23d2347c52c08 /ChangeLog | |
| parent | fee9eb6200f0e44a4b684903bc47fde36d46f1a5 (diff) | |
| download | glibc-f83bb9b8e97656ae0d3e2a31e859363e2d4d5832.tar.xz glibc-f83bb9b8e97656ae0d3e2a31e859363e2d4d5832.zip | |
posix: Remove dynamic memory allocation from execl{e,p}
GLIBC execl{e,p} implementation might use malloc if the total number of
arguments exceed initial assumption size (1024). This might lead to
issues in two situations:
1. execl/execle is stated to be async-signal-safe by POSIX [1]. However
if execl is used in a signal handler with a large argument set (that
may call malloc internally) and if the resulting call fails it might
lead malloc in the program in a bad state.
2. If the functions are used in a vfork/clone(VFORK) situation it also
might issue malloc internal bad state.
This patch fixes it by using stack allocation instead. It also fixes
BZ#19534.
Tested on x86_64.
[1] http://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html
[BZ #19534]
* posix/execl.c (execl): Remove dynamic memory allocation.
* posix/execle.c (execle): Likewise.
* posix/execlp.c (execlp): Likewise.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 7 |
1 files changed, 7 insertions, 0 deletions
@@ -1,3 +1,10 @@ +2016-03-07 Adhemerval Zanella <adhemerval.zanella@linaro.org> + + [BZ #19534] + * posix/execl.c (execl): Remove dynamic memory allocation. + * posix/execle.c (execle): Likewise. + * posix/execlp.c (execlp): Likewise. + 2016-03-06 H.J. Lu <hongjiu.lu@intel.com> * sysdeps/x86_64/multiarch/memcpy-avx512-no-vzeroupper.S: |