diff options
| author | Aurelien Jarno <aurelien@aurel32.net> | 2024-12-19 23:55:15 +0100 |
|---|---|---|
| committer | Aurelien Jarno <aurelien@aurel32.net> | 2024-12-20 22:57:06 +0100 |
| commit | 6fd215d6ae9a4a6e75f7ea18d89db6a10f158eaf (patch) | |
| tree | b3d47d641b9306d97618c4327398d7dc12358b79 /sysdeps/posix | |
| parent | 034cd675286db07110a773fdb6a857285485d2d4 (diff) | |
| download | glibc-6fd215d6ae9a4a6e75f7ea18d89db6a10f158eaf.tar.xz glibc-6fd215d6ae9a4a6e75f7ea18d89db6a10f158eaf.zip | |
posix: fix system when a child cannot be created [BZ #32450]
POSIX states that "if a child process cannot be created, or if the
termination status for the command language interpreter cannot be
obtained, system() shall return -1 and set errno to indicate the error."
In the glibc implementation it could happen when posix_spawn fails,
which happens when the underlying fork, vfork, or clone call fails. They
could fail with EAGAIN and ENOMEM.
Resolves: BZ #32450
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Diffstat (limited to 'sysdeps/posix')
| -rw-r--r-- | sysdeps/posix/system.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/sysdeps/posix/system.c b/sysdeps/posix/system.c index be32704280..f3e173e465 100644 --- a/sysdeps/posix/system.c +++ b/sysdeps/posix/system.c @@ -175,10 +175,14 @@ do_system (const char *line) __libc_cleanup_region_end (0); #endif } + else if (ret == EAGAIN || ret == ENOMEM) + /* POSIX states that failure to create a child process should + return -1. */ + status = -1; else - /* POSIX states that failure to execute the shell should return - as if the shell had terminated using _exit(127). */ - status = W_EXITCODE (127, 0); + /* POSIX states that failure to execute the shell should return + as if the shell had terminated using _exit(127). */ + status = W_EXITCODE (127, 0); /* sigaction can not fail with SIGINT/SIGQUIT used with old disposition. Same applies for sigprocmask. */ |