diff options
25 files changed, 275 insertions, 584 deletions
@@ -1,5 +1,39 @@ 2017-04-11 Adhemerval Zanella <adhemerval.zanella@linaro.org> + [BZ #21270] + * posix/tst-mmap-offset.c (do_prepare): New function. + (do_test): Rename to do_test_bz18877 and use FAIL_RET. + (do_test_bz21270): New function. + * sysdeps/unix/sysv/linux/aarch64/mmap.c: Remove file. + * sysdeps/unix/sysv/linux/arm/mmap.c: Remove file. + * sysdeps/unix/sysv/linux/generic/wordsize-32/mmap.c: Likewise. + * sysdeps/unix/sysv/linux/hppa/mmap.c: Likewise. + * sysdeps/unix/sysv/linux/i386/mmap.c: Likewise. + * sysdeps/unix/sysv/linux/m68k/mmap.S: Likewise. + * sysdeps/unix/sysv/linux/m68k/mmap64.c: Likewise. + * sysdeps/unix/sysv/linux/microblaze/mmap.S: Likewise. + * sysdeps/unix/sysv/linux/mips/mips32/mmap.c: Likewise. + * sysdeps/unix/sysv/linux/mips/mips64/n32/mmap.c: Likewise. + * sysdeps/unix/sysv/linux/mips/mips64/n64/mmap64.c: Likewise. + * sysdeps/unix/sysv/linux/s390/s390-32/mmap.S: Likewise. + * sysdeps/unix/sysv/linux/s390/s390-32/mmap64.S: Likewise. + * sysdeps/unix/sysv/linux/s390/s390-64/mmap.S: Likewise. + * sysdeps/unix/sysv/linux/wordsize-64/mmap.c: Likewise. + * sysdeps/unix/sysv/linux/wordsize-64/mmap64.c: Likewise. + * sysdeps/unix/sysv/linux/x86_64/64/mmap.c: Likewise. + * sysdeps/unix/sysv/linux/mmap_internal.h: New file. + * sysdeps/unix/sysv/linux/m68k/mmap_internal.h: Likewise. + * sysdeps/unix/sysv/linux/mips/mips64/n32/mmap_internal.h: Likewise. + * sysdeps/unix/sysv/linux/s390/mmap_internal.h: Likewise. + * sysdeps/unix/sysv/linux/x86_64/64/mmap_internal.h: Likewise. + * sysdeps/unix/sysv/linux/mips/mips64/n64/syscalls.list: Remove mmap + from auto-generation list. + * sysdeps/unix/sysv/linux/mips/mips64/n32/syscalls.list: Likewise. + * sysdeps/unix/sysv/linux/wordsize-64/syscalls.list: Likewise. + * sysdeps/unix/sysv/linux/mmap.c: New file. + * sysdeps/unix/sysv/linux/mmap64.c (__mmap64): Add check for invalid + offsets and support for mmap2 syscall. + * posix/globtest.sh: Add cleanup routine on trap 0. 2017-04-11 Wainer dos Santos Moschetta <wainersm@linux.vnet.ibm.com> diff --git a/posix/tst-mmap-offset.c b/posix/tst-mmap-offset.c index d139c301d7..385df289e6 100644 --- a/posix/tst-mmap-offset.c +++ b/posix/tst-mmap-offset.c @@ -1,4 +1,4 @@ -/* BZ #18877 mmap offset test. +/* BZ #18877 and #21270 mmap offset test. Copyright (C) 2015-2017 Free Software Foundation, Inc. This file is part of the GNU C Library. @@ -21,18 +21,37 @@ #include <stdlib.h> #include <string.h> #include <unistd.h> +#include <errno.h> #include <sys/mman.h> -static int -printmsg (int rc, const char *msg) +#include <support/check.h> + +static int fd; +static long int page_shift; +static char fname[] = "tst-mmap-offset-XXXXXX"; + +static void +do_prepare (int argc, char **argv) { - printf ("%s failed: %m\n", msg); - return rc; + fd = mkstemp64 (fname); + if (fd < 0) + FAIL_EXIT1 ("mkstemp failed"); + + if (unlink (fname)) + FAIL_EXIT1 ("unlink failed"); + + long sz = sysconf(_SC_PAGESIZE); + if (sz == -1) + sz = 4096L; + page_shift = ffs (sz) - 1; } +#define PREPARE do_prepare + + /* Check if negative offsets are handled correctly by mmap. */ static int -do_test (void) +do_test_bz18877 (void) { const int prot = PROT_READ | PROT_WRITE; const int flags = MAP_SHARED; @@ -40,22 +59,13 @@ do_test (void) const unsigned long offset = 0xace00000; const unsigned long size = offset + length; void *addr; - int fd; - char fname[] = "tst-mmap-offset-XXXXXX"; - - fd = mkstemp64 (fname); - if (fd < 0) - return printmsg (1, "mkstemp"); - - if (unlink (fname)) - return printmsg (1, "unlink"); if (ftruncate64 (fd, size)) - return printmsg (0, "ftruncate64"); + FAIL_RET ("ftruncate64 failed"); addr = mmap (NULL, length, prot, flags, fd, offset); if (MAP_FAILED == addr) - return printmsg (1, "mmap"); + FAIL_RET ("mmap failed"); /* This memcpy is likely to SIGBUS if mmap has messed up with offset. */ memcpy (addr, fname, sizeof (fname)); @@ -63,5 +73,45 @@ do_test (void) return 0; } -#define TEST_FUNCTION do_test () -#include "../test-skeleton.c" +/* Check if invalid offset are handled correctly by mmap. */ +static int +do_test_bz21270 (void) +{ + /* For architectures with sizeof (off_t) < sizeof (off64_t) mmap is + implemented with __SYS_mmap2 syscall and the offset is represented in + multiples of page size. For offset larger than + '1 << (page_shift + 8 * sizeof (off_t))' (that is, 1<<44 on system with + page size of 4096 bytes) the system call silently truncates the offset. + For this case glibc mmap implementation returns EINVAL. */ + const int prot = PROT_READ | PROT_WRITE; + const int flags = MAP_SHARED; + const int64_t offset = 1ULL << (page_shift + 8 * sizeof (uint32_t)); + const size_t length = 4096; + + void *addr = mmap64 (NULL, length, prot, flags, fd, offset); + if (sizeof (off_t) < sizeof (off64_t)) + { + if ((addr != MAP_FAILED) && (errno != EINVAL)) + FAIL_RET ("mmap succeed"); + } + else + { + if (addr == MAP_FAILED) + FAIL_RET ("mmap failed"); + } + + return 0; +} + +int +do_test (void) +{ + int ret = 0; + + ret += do_test_bz18877 (); + ret += do_test_bz21270 (); + + return ret; +} + +#include <support/test-driver.c> diff --git a/sysdeps/unix/sysv/linux/aarch64/mmap.c b/sysdeps/unix/sysv/linux/aarch64/mmap.c deleted file mode 100644 index 1dd18f97a2..0000000000 --- a/sysdeps/unix/sysv/linux/aarch64/mmap.c +++ /dev/null @@ -1,34 +0,0 @@ -/* Copyright (C) 2009-2017 Free Software Foundation, Inc. - - This file is part of the GNU C Library. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public License as - published by the Free Software Foundation; either version 2.1 of the - License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library; if not, see - <http://www.gnu.org/licenses/>. */ - -#include <sys/types.h> -#include <sys/mman.h> -#include <errno.h> -#include <sys/syscall.h> -#include <sysdep.h> -#include <unistd.h> - -__ptr_t -__mmap (__ptr_t addr, size_t len, int prot, int flags, int fd, off_t offset) -{ - return (__ptr_t) INLINE_SYSCALL (mmap, 6, addr, len, prot, flags, fd, offset); -} - -weak_alias (__mmap, mmap) -weak_alias (__mmap, mmap64) -weak_alias (__mmap, __mmap64) diff --git a/sysdeps/unix/sysv/linux/generic/wordsize-32/mmap.c b/sysdeps/unix/sysv/linux/generic/wordsize-32/mmap.c deleted file mode 100644 index ebeb79b543..0000000000 --- a/sysdeps/unix/sysv/linux/generic/wordsize-32/mmap.c +++ /dev/null @@ -1,40 +0,0 @@ -/* Copyright (C) 2011-2017 Free Software Foundation, Inc. - This file is part of the GNU C Library. - Contributed by Chris Metcalf <cmetcalf@tilera.com>, 2011. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library. If not, see - <http://www.gnu.org/licenses/>. */ - -#include <sys/types.h> -#include <sys/mman.h> -#include <errno.h> -#include <sysdep.h> - -#ifndef MMAP_PAGE_UNIT -# define MMAP_PAGE_UNIT 4096UL -#endif - -__ptr_t -__mmap (__ptr_t addr, size_t len, int prot, int flags, int fd, off_t offset) -{ - if (offset & (MMAP_PAGE_UNIT - 1)) - { - __set_errno (EINVAL); - return MAP_FAILED; - } - return (__ptr_t) INLINE_SYSCALL (mmap2, 6, addr, len, prot, flags, fd, - offset / MMAP_PAGE_UNIT); -} - -weak_alias (__mmap, mmap) diff --git a/sysdeps/unix/sysv/linux/hppa/mmap.c b/sysdeps/unix/sysv/linux/hppa/mmap.c deleted file mode 100644 index 72957cd22c..0000000000 --- a/sysdeps/unix/sysv/linux/hppa/mmap.c +++ /dev/null @@ -1,49 +0,0 @@ -/* Copyright (C) 1994-2017 Free Software Foundation, Inc. - This file is part of the GNU C Library. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library. If not, see - <http://www.gnu.org/licenses/>. */ - -#include <sys/types.h> -#include <sys/mman.h> -#include <errno.h> - -/* Map addresses starting near ADDR and extending for LEN bytes. From - OFFSET into the file FD describes according to PROT and FLAGS. If ADDR - is nonzero, it is the desired mapping address. If the MAP_FIXED bit is - set in FLAGS, the mapping will be at ADDR exactly (which must be - page-aligned); otherwise the system chooses a convenient nearby address. - The return value is the actual mapping address chosen or MAP_FAILED - for errors (in which case `errno' is set). A successful `mmap' call - deallocates any previous mapping for the affected region. */ - -#include <sysdep.h> - -__ptr_t -__mmap (__ptr_t addr, size_t len, int prot, int flags, int fd, off_t offset) -{ - - __ptr_t ret; - - ret = (__ptr_t) INLINE_SYSCALL (mmap, 6, addr, len, prot, flags, fd, offset); - - /* check if it's really a negative number */ - if(((unsigned long)ret & 0xfffff000) == 0xfffff000) - return MAP_FAILED; - - return ret; - -} - -weak_alias (__mmap, mmap) diff --git a/sysdeps/unix/sysv/linux/m68k/mmap.S b/sysdeps/unix/sysv/linux/m68k/mmap.S deleted file mode 100644 index eb8e0716b8..0000000000 --- a/sysdeps/unix/sysv/linux/m68k/mmap.S +++ /dev/null @@ -1,42 +0,0 @@ -/* Copyright (C) 1996-2017 Free Software Foundation, Inc. - This file is part of the GNU C Library. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library. If not, see - <http://www.gnu.org/licenses/>. */ - -#include <sysdep.h> - - .text -ENTRY (__mmap) - - move.l #SYS_ify (mmap), %d0 /* System call number in %d0. */ - - lea 4(%sp), %a0 /* Address of args is 1st arg. */ - move.l %a0, %d1 - - /* Do the system call trap. */ - trap #0 - - /* Kludge: negative numbers are among the legal return values. - If %d0 is between -4096 and 0 then there was an error. */ - cmp.l #-4096, %d0 - jhi SYSCALL_ERROR_LABEL - - /* Successful; return the syscall's value. Copy it to %a0 because - mmap is declared to return a pointer. */ - move.l %d0, %a0 - rts -PSEUDO_END (__mmap) - -weak_alias (__mmap, mmap) diff --git a/sysdeps/unix/sysv/linux/m68k/mmap64.c b/sysdeps/unix/sysv/linux/m68k/mmap64.c deleted file mode 100644 index 8bf8987017..0000000000 --- a/sysdeps/unix/sysv/linux/m68k/mmap64.c +++ /dev/null @@ -1,5 +0,0 @@ -/* ColdFire and Sun 3 kernels have PAGE_SHIFT set to 13 and expect - mmap2 offset to be provided in 8K pages. Determine the shift - dynamically with getpagesize. */ -#define MMAP2_PAGE_SHIFT -1 -#include <sysdeps/unix/sysv/linux/mmap64.c> diff --git a/sysdeps/unix/sysv/linux/arm/mmap.c b/sysdeps/unix/sysv/linux/m68k/mmap_internal.h index 4fe8678ea5..bd8bd3843b 100644 --- a/sysdeps/unix/sysv/linux/arm/mmap.c +++ b/sysdeps/unix/sysv/linux/m68k/mmap_internal.h @@ -1,4 +1,5 @@ -/* Copyright (C) 2015-2017 Free Software Foundation, Inc. +/* Common mmap definition for Linux implementation. Linux/m68k version. + Copyright (C) 2017 Free Software Foundation, Inc. This file is part of the GNU C Library. The GNU C Library is free software; you can redistribute it and/or @@ -15,4 +16,14 @@ License along with the GNU C Library; if not, see <http://www.gnu.org/licenses/>. */ -#include <sysdeps/unix/sysv/linux/generic/wordsize-32/mmap.c> +#ifndef MMAP_M68K_INTERNAL_LINUX_H +#define MMAP_M68K_INTERNAL_LINUX_H + +/* ColdFire and Sun 3 kernels have PAGE_SHIFT set to 13 and expect + mmap2 offset to be provided in 8K pages. Determine the shift + dynamically with getpagesize. */ +#define MMAP2_PAGE_SHIFT -1 + +#include_next <mmap_internal.h> + +#endif diff --git a/sysdeps/unix/sysv/linux/microblaze/mmap.S b/sysdeps/unix/sysv/linux/microblaze/mmap.S deleted file mode 100644 index 0099993a89..0000000000 --- a/sysdeps/unix/sysv/linux/microblaze/mmap.S +++ /dev/null @@ -1,50 +0,0 @@ -/* Copyright (C) 2009-2017 Free Software Foundation, Inc. - - This file is part of the GNU C Library. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public License as - published by the Free Software Foundation; either version 2.1 of the - License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library; if not, see - <http://www.gnu.org/licenses/>. */ - -#include <sysdep.h> - -#define EINVAL 22 - .text -ENTRY (__mmap) - addik r3,r0,-EINVAL - andi r4,r10,0xfff - bnei r4,L(skip) - addik r12,r0,SYS_ify(mmap2) - sra r10,r10 - sra r10,r10 - sra r10,r10 - sra r10,r10 - sra r10,r10 - sra r10,r10 - sra r10,r10 - sra r10,r10 - sra r10,r10 - sra r10,r10 - sra r10,r10 - sra r10,r10 ; /* mmap2 takes the offset in pages. */ - brki r14,8 - nop -L(skip): - addik r4,r0,-4095 - cmpu r4,r4,r3 - bgei r4,SYSCALL_ERROR_LABEL - rtsd r15,8 - nop -PSEUDO_END (__mmap) - -weak_alias (__mmap, mmap) diff --git a/sysdeps/unix/sysv/linux/mips/mips32/mmap.c b/sysdeps/unix/sysv/linux/mips/mips32/mmap.c deleted file mode 100644 index f30b1da58e..0000000000 --- a/sysdeps/unix/sysv/linux/mips/mips32/mmap.c +++ /dev/null @@ -1 +0,0 @@ -#include <sysdeps/unix/sysv/linux/generic/wordsize-32/mmap.c> diff --git a/sysdeps/unix/sysv/linux/mips/mips64/n32/mmap.c b/sysdeps/unix/sysv/linux/mips/mips64/n32/mmap_internal.h index ca0a5b1442..4b65559ecb 100644 --- a/sysdeps/unix/sysv/linux/mips/mips64/n32/mmap.c +++ b/sysdeps/unix/sysv/linux/mips/mips64/n32/mmap_internal.h @@ -1,4 +1,4 @@ -/* mmap for MIPS n32. +/* Common mmap definition for Linux implementation. MIPS n32 version. Copyright (C) 2016-2017 Free Software Foundation, Inc. This file is part of the GNU C Library. @@ -16,20 +16,13 @@ License along with the GNU C Library. If not, see <http://www.gnu.org/licenses/>. */ -#include <sys/types.h> -#include <sys/mman.h> -#include <errno.h> -#include <stdint.h> -#include <sysdep.h> +#ifndef MMAP_MIPS_N32_INTERNAL_H +#define MMAP_MIPS_N32_INTERNAL_H -__ptr_t -__mmap (__ptr_t addr, size_t len, int prot, int flags, int fd, off_t offset) -{ - /* To handle negative offsets consistently with other architectures, - the offset must be zero-extended to 64-bit. */ - uint64_t offset_adj = (uint64_t) (uint32_t) offset; - return (__ptr_t) INLINE_SYSCALL (mmap, 6, addr, len, prot, flags, fd, - offset_adj); -} +/* To handle negative offsets consistently with other architectures, + the offset must be zero-extended to 64-bit. */ +#define MMAP_ADJUST_OFFSET(offset) (uint64_t) (uint32_t) offset -weak_alias (__mmap, mmap) +#include_next <mmap_internal.h> + +#endif diff --git a/sysdeps/unix/sysv/linux/mips/mips64/n32/syscalls.list b/sysdeps/unix/sysv/linux/mips/mips64/n32/syscalls.list index 7af317f69c..5f3d04728d 100644 --- a/sysdeps/unix/sysv/linux/mips/mips64/n32/syscalls.list +++ b/sysdeps/unix/sysv/linux/mips/mips64/n32/syscalls.list @@ -4,8 +4,6 @@ # return value. lseek64 - lseek i:iii __lseek64 __libc_lseek64 lseek64 llseek -mmap64 - mmap b:aniiii __mmap64 mmap64 - readahead - readahead i:iii __readahead readahead prlimit64 EXTRA prlimit64 i:iipp prlim |