diff options
| -rw-r--r-- | ChangeLog | 57 | ||||
| -rw-r--r-- | FAQ | 95 | ||||
| -rw-r--r-- | bits/libc-tsd.h | 51 | ||||
| -rw-r--r-- | db2/progs/db_load/db_load.c | 4 | ||||
| -rw-r--r-- | elf/dl-error.c | 45 | ||||
| -rw-r--r-- | linuxthreads/ChangeLog | 22 | ||||
| -rw-r--r-- | linuxthreads/Makefile | 2 | ||||
| -rw-r--r-- | linuxthreads/internals.h | 2 | ||||
| -rw-r--r-- | linuxthreads/no-tsd.c | 33 | ||||
| -rw-r--r-- | linuxthreads/specific.c | 10 | ||||
| -rw-r--r-- | linuxthreads/sysdeps/pthread/bits/libc-lock.h | 17 | ||||
| -rw-r--r-- | linuxthreads/sysdeps/pthread/bits/libc-tsd.h | 43 | ||||
| -rw-r--r-- | malloc/thread-m.h | 38 | ||||
| -rw-r--r-- | misc/err.h | 23 | ||||
| -rw-r--r-- | nscd/nscd_getpw_r.c | 1 | ||||
| -rw-r--r-- | sysdeps/generic/bits/libc-tsd.h | 51 | ||||
| -rw-r--r-- | sysdeps/generic/errno-loc.c | 5 | ||||
| -rw-r--r-- | sysdeps/i386/bits/string.h | 16 | ||||
| -rw-r--r-- | sysdeps/i386/i486/bits/string.h | 99 | ||||
| -rw-r--r-- | sysdeps/mach/hurd/bits/libc-tsd.h | 37 | ||||
| -rw-r--r-- | sysdeps/unix/sysv/linux/alpha/bits/ipc.h | 9 | ||||
| -rw-r--r-- | sysdeps/unix/sysv/linux/i386/setfsgid.c | 2 | ||||
| -rw-r--r-- | sysdeps/unix/sysv/linux/i386/setfsuid.c | 2 |
23 files changed, 524 insertions, 140 deletions
@@ -1,3 +1,60 @@ +1998-11-30 Andreas Jaeger <aj@arthur.rhein-neckar.de> + + * nscd/nscd_getpw_r.c: Include nscd_proto.h for prototypes. + + * sysdeps/generic/errno-loc.c: Include <errno.h> for prototype, + undefine errno to get variable. + + * sysdeps/unix/sysv/linux/i386/setfsuid.c: Include <sys/fsuid.h> + instead of <unistd.h> for prototype. + * sysdeps/unix/sysv/linux/i386/setfsgid.c: Likewise. + +1998-11-30 Ulrich Drepper <drepper@cygnus.com> + + * misc/err.h: Correct comments and use protected attribute keywords. + Reported by Joseph Myers <jsm28@cam.ac.uk>. + +1998-11-29 Roland McGrath <roland@baalperazim.frob.com> + + * malloc/thread-m.h [_LIBC]: Include <bits/libc-tsd.h>, and + remove tsd stuff from pthreads/cthreads libc sections. + Use __libc_tsd_define for MALLOC key. + [_LIBC] (tsd_key_t, tsd_key_create): Define to a zero-size type and a + no-op, respectively. + [_LIBC] (tsd_setspecific, tsd_getspecific): Use __libc_tsd_get/set. + + * elf/dl-error.c: Include <bits/libc-tsd.h>. + Use __libc_tsd_define for DL_ERROR key. + (tsd_setspecific, tsd_getspecific): Rewritten using __libc_tsd_get/set. + + * sysdeps/mach/hurd/bits/libc-tsd.h: New file. + * sysdeps/generic/bits/libc-tsd.h: New file. + * Makefile (distribute): Add bits/libc-tsd.h. + +1998-10-12 Roland McGrath <roland@baalperazim.frob.com> + + * elf/dl-error.c: Remove kludge to check for ld.so load address. + There is no need if weak undefined symbols are not used in ld.so; + see linuxthreads/ChangeLog for changes to files + linuxthreads/sysdeps/pthread/bits/libc-lock.h and + linuxthreads/sysdeps/pthread/bits/libc-tsd.h. + +1998-11-30 Andreas Jaeger <aj@arthur.rhein-neckar.de> + + * sysdeps/i386/bits/string.h (__memset_cc): Fix typo (s->__s). + + * sysdeps/i386/i486/bits/string.h: Add prototypes for all new + inline functions. + * sysdeps/i386/bits/string.h: Likewise. + +1998-11-30 Andreas Jaeger <aj@arthur.rhein-neckar.de> + + * sysdeps/unix/sysv/linux/alpha/bits/ipc.h: Remove ipc_kludge. + +1998-11-30 Andreas Schwab <schwab@issan.cs.uni-dortmund.de> + + * db2/progs/db_load/db_load.c (main): Avoid -Wparentheses warning. + 1998-09-12 Mark Kettenis <kettenis@phys.uva.nl> * sysdeps/mach/hurd/dl-sysdep.c: Do not define @@ -24,22 +24,23 @@ please let me know. What's wrong? 1.4. Do I need a special linker or assembler? 1.5. Which compiler should I use for powerpc? -1.6. Do I need some more things to compile the GNU C Library? -1.7. What version of the Linux kernel headers should be used? -1.8. The compiler hangs while building iconvdata modules. What's +1.6. Which tools should I use for ARM? +1.7. Do I need some more things to compile the GNU C Library? +1.8. What version of the Linux kernel headers should be used? +1.9. The compiler hangs while building iconvdata modules. What's wrong? -1.9. When I run `nm -u libc.so' on the produced library I still +1.10. When I run `nm -u libc.so' on the produced library I still find unresolved symbols. Can this be ok? -1.10. What are these `add-ons'? -1.11. My XXX kernel emulates a floating-point coprocessor for me. +1.11. What are these `add-ons'? +1.12. My XXX kernel emulates a floating-point coprocessor for me. Should I enable --with-fp? -1.12. When compiling GNU libc I get lots of errors saying functions +1.13. When compiling GNU libc I get lots of errors saying functions in glibc are duplicated in libgcc. -1.13. Why do I get messages about missing thread functions when I use +1.14. Why do I get messages about missing thread functions when I use librt? I don't even use threads. -1.14. What's the problem with configure --enable-omitfp? -1.15. I get failures during `make check'. What shall I do? -1.16. What is symbol versioning good for? Do I need it? +1.15. What's the problem with configure --enable-omitfp? +1.16. I get failures during `make check'. What shall I do? +1.17. What is symbol versioning good for? Do I need it? 2. Installation and configuration issues @@ -140,6 +141,8 @@ please let me know. to EST5EDT things go wrong since glibc computes the wrong time from this information. 4.4. What other sources of documentation about glibc are available? +4.5. The timezone string for Sydney/Australia is wrong since even when + daylight saving time is in effect the timezone string is EST. ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ @@ -163,6 +166,7 @@ in the future, are: sparc-*-linux-gnu Linux-2.x on SPARC sparc64-*-linux-gnu Linux-2.x on UltraSPARC arm-*-none ARM standalone systems + arm-*-linux Linux-2.x on ARM arm-*-linuxaout Linux-2.x on ARM using a.out binaries Ports to other Linux platforms are in development, and may in fact work @@ -191,7 +195,7 @@ a local mirror first. You should always try to use the latest official release. Older versions may not have all the features GNU libc requires. The current releases of egcs (1.0.3 and 1.1) and GNU CC (2.8.1) should work with the GNU C library -(for powerpc see question question 1.5). +(for powerpc see question question 1.5; for ARM see question question 1.6). {ZW} You may have problems if you try to mix code compiled with EGCS and with GCC 2.8.1. See question 2.8 for details. @@ -240,7 +244,18 @@ variables. There is a temporary patch at: Later versions of egcs may fix this problem. -1.6. Do I need some more things to compile the GNU C Library? +1.6. Which tools should I use for ARM? + +{PB} You should use egcs 1.1 or a later version. For ELF systems some +changes are needed to the compiler; a patch against egcs-1.1.x can be found +at: + +<ftp://ftp.netwinder.org/users/p/philb/egcs-1.1.1pre2-diff-981126> + +Binutils 2.9.1.0.16 or later is also required. + + +1.7. Do I need some more things to compile the GNU C Library? {UD} Yes, there are some more :-). @@ -284,7 +299,7 @@ Later versions of egcs may fix this problem. If you have some more measurements let me know. -1.7. What version of the Linux kernel headers should be used? +1.8. What version of the Linux kernel headers should be used? {AJ,UD} The headers from the most recent Linux kernel should be used. The headers used while compiling the GNU C library and the kernel binary used @@ -307,7 +322,7 @@ kernel sources to the 2.1 tree, do `make oldconfig', and say no to all the new options. -1.8. The compiler hangs while building iconvdata modules. What's +1.9. The compiler hangs while building iconvdata modules. What's wrong? {ZW} This is a problem with old versions of GCC. Initialization of large @@ -317,7 +332,7 @@ time. The problem is fixed in egcs 1.1 but not in earlier releases. -1.9. When I run `nm -u libc.so' on the produced library I still +1.10. When I run `nm -u libc.so' on the produced library I still find unresolved symbols. Can this be ok? {UD} Yes, this is ok. There can be several kinds of unresolved symbols: @@ -333,7 +348,7 @@ Generally, you should make sure you find a real program which produces errors while linking before deciding there is a problem. -1.10. What are these `add-ons'? +1.11. What are these `add-ons'? {UD} To avoid complications with export rules or external source code some optional parts of the libc are distributed as separate packages (e.g., the @@ -356,7 +371,7 @@ else. The existing makefiles do most of the work; only some few stub rules must be written to get everything running. -1.11. My XXX kernel emulates a floating-point coprocessor for me. +1.12. My XXX kernel emulates a floating-point coprocessor for me. Should I enable --with-fp? {ZW} An emulated FPU is just as good as a real one, as far as the C library @@ -370,7 +385,7 @@ far more trouble than it's worth: you then have to compile (libgcc.a for GNU C), because the calling conventions change. -1.12. When compiling GNU libc I get lots of errors saying functions +1.13. When compiling GNU libc I get lots of errors saying functions in glibc are duplicated in libgcc. {EY} This is *exactly* the same problem that I was having. The problem was @@ -387,7 +402,7 @@ problems of this kind. The setting of CFLAGS is checked at the very beginning and if it is not usable `configure' will bark. -1.13. Why do I get messages about missing thread functions when I use +1.14. Why do I get messages about missing thread functions when I use librt? I don't even use threads. {UD} In this case you probably mixed up your installation. librt uses @@ -403,7 +418,7 @@ given path to find the implicitly referenced library while not disturbing any other link path. -1.14. What's the problem with configure --enable-omitfp? +1.15. What's the problem with configure --enable-omitfp? {AJ} When --enable-omitfp is set the libraries are built without frame pointers. Some compilers produce buggy code for this model and therefore we @@ -422,7 +437,7 @@ The compilation of these extra libraries and the compiler optimizations slow down the build process and need more disk space. -1.15. I get failures during `make check'. What shall I do? +1.16. I get failures during `make check'. What shall I do? {AJ} The testsuite should compile and run cleanly on your system, every failure should be looked into. Depending on the failure I wouldn't advise @@ -445,7 +460,7 @@ There are some failures which are not directly related to the GNU libc: development kernels have fixes for the floating point support on Alpha. -1.16. What is symbol versioning good for? Do I need it? +1.17. What is symbol versioning good for? Do I need it? {AJ} Symbol versioning solves problems that are related to interface changes. One version of an interface might have been introduced in a @@ -565,7 +580,7 @@ question 3.8 for details. source code. Until this law gets abolished we cannot ship the cryptographic functions together with glibc. -The functions are available, as an add-on (see question 1.10). People in the US +The functions are available, as an add-on (see question 1.11). People in the US may get it from the same place they got GNU libc from. People outside the US should get the code from ftp://ftp.ifi.uio.no/pub/gnu, or another archive site outside the USA. The README explains how to install the sources. @@ -1333,9 +1348,20 @@ from your favorite mirror of ftp.gnu.org. where the headers are stable. There are still lots of incompatible changes made and the libc headers have to follow. -Also, make sure you have a suitably recent kernel. As of the 970401 -snapshot, according to Philip Blundell <Philip.Blundell@pobox.com>, the -required kernel version is at least 2.1.30. +{PB} The 2.1 release of GNU libc aims to comply with the current versions of +all the relevant standards. The IPv6 support libraries for older Linux +systems used a different naming convention and so code written to work with +them may need to be modified. If the standards make incompatible changes in +the future then the libc may need to change again. + +IPv6 will not work with a 2.0.x kernel. When kernel 2.2 is released it +should contain all the necessary support; until then you should use the +latest 2.1.x release you can find. As of 98/11/26 the currently recommended +kernel for IPv6 is 2.1.129. + +Also, as of the 2.1 release the IPv6 API provided by GNU libc is not +100% complete. In particular the getipnodebyname and getipnodebyaddr +functions are not implemented. 4.3. When I set the timezone by setting the TZ environment variable @@ -1375,6 +1401,21 @@ Looijaard describes a different way installing glibc2 as secondary libc at Please note that this is not a complete list. + +4.5. The timezone string for Sydney/Australia is wrong since even when + daylight saving time is in effect the timezone string is EST. + +{UD} The problem for some timezones is that the local authorities decided +to use the term "summer time" instead of "daylight saving time". In this +case the abbreviation character `S' is the same as the standard one. So, +for Sydney we have + + Eastern Standard Time = EST + Eastern Summer Time = EST + +Great! To get this bug fixed convince the authorities to change the laws +and regulations of the country this effects. glibc behaves correctly. + ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ diff --git a/bits/libc-tsd.h b/bits/libc-tsd.h new file mode 100644 index 0000000000..6048d995c8 --- /dev/null +++ b/bits/libc-tsd.h @@ -0,0 +1,51 @@ +/* libc-internal interface for thread-specific data. Stub version. + Copyright (C) 1998 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Library General Public License as + published by the Free Software Foundation; either version 2 of the + License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Library General Public License for more details. + + You should have received a copy of the GNU Library General Public + License along with the GNU C Library; see the file COPYING.LIB. If not, + write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, + Boston, MA 02111-1307, USA. */ + +#ifndef _BITS_LIBC_TSD_H +#define _BITS_LIBC_TSD_H 1 + +/* This file defines the following macros for accessing a small fixed + set of thread-specific `void *' data used only internally by libc. + + __libc_tsd_define(CLASS, KEY) -- Define or declare a `void *' datum + for KEY. CLASS can be `static' for + keys used in only one source file, + empty for global definitions, or + `extern' for global declarations. + __libc_tsd_get(KEY) -- Return the `void *' datum for KEY. + __libc_tsd_set(KEY, VALUE) -- Set the datum for KEY to VALUE. + + The set of available KEY's will usually be provided as an enum, + and contains (at least): + _LIBC_TSD_KEY_MALLOC + _LIBC_TSD_KEY_DL_ERROR + All uses must be the literal _LIBC_TSD_* name in the __libc_tsd_* macros. + Some implementations may not provide any enum at all and instead + using string pasting in the macros. */ + +/* This is the generic/stub implementation for wholly single-threaded + systems. We don't define an enum for the possible key values, because + the KEYs translate directly into variables by macro magic. */ + +#define __libc_tsd_define(CLASS, KEY) CLASS void *__libc_tsd_##KEY##_data; +#define __libc_tsd_get(KEY) (__libc_tsd_##KEY##_data) +#define __libc_tsd_set(KEY, VALUE) (__libc_tsd_##KEY##_data = (VALUE)) + + +#endif /* bits/libc-tsd.h */ diff --git a/db2/progs/db_load/db_load.c b/db2/progs/db_load/db_load.c index 5ac17753f5..84cfb36775 100644 --- a/db2/progs/db_load/db_load.c +++ b/db2/progs/db_load/db_load.c @@ -161,7 +161,7 @@ main(argc, argv) /* Get each key/data pair and add them to the database. */ for (recno = 1;; ++recno) { - if (dbtype == DB_RECNO) + if (dbtype == DB_RECNO) { if (checkprint) { if (dbt_rprint(&data)) break; @@ -169,7 +169,7 @@ main(argc, argv) if (dbt_rdump(&data)) break; } - else + } else if (checkprint) { if (dbt_rprint(&key)) break; diff --git a/elf/dl-error.c b/elf/dl-error.c index ae63447453..9ccc193a66 100644 --- a/elf/dl-error.c +++ b/elf/dl-error.c @@ -22,7 +22,7 @@ #include <string.h> #include <unistd.h> #include <elf/ldsodefs.h> -#include <bits/libc-lock.h> +#include <bits/libc-tsd.h> /* This structure communicates state between _dl_catch_error and _dl_signal_error. */ @@ -36,44 +36,11 @@ struct catch calls can come from `_dl_map_object_deps', `_dlerror_run', or from any of the libc functionality which loads dynamic objects (NSS, iconv). Therefore we have to be prepared to save the state in thread-local - memory. `catch' will only be used for the non-threaded case. - - Please note the horrible kludge we have to use to check for the - thread functions to be defined. The problem is that while running - ld.so standalone (i.e., before the relocation with the available - libc symbols) we do not have a real handling of undefined weak symbols. - All symbols are relocated, regardless of the availability. They are - relocated relative to the load address of the dynamic linker. Adding - this start address to zero (the value in the GOT for undefined symbols) - leads to an address which is the load address of ld.so. Once we have - relocated with the libc values the value is NULL if the function is - not available. Our "solution" is to regard NULL and the ld.so load - address as indicators for unavailable weak symbols. */ -static struct catch *catch; - -#ifdef PIC -# define tsd_setspecific(data) \ - if (__libc_internal_tsd_set != (void *) _dl_rtld_map.l_addr \ - && __libc_internal_tsd_set != NULL) \ - __libc_internal_tsd_set (_LIBC_TSD_KEY_DL_ERROR, data); \ - else \ - catch = (data) -# define tsd_getspecific() \ - (__libc_internal_tsd_set != (void *) _dl_rtld_map.l_addr \ - && __libc_internal_tsd_set != NULL \ - ? (struct catch *) __libc_internal_tsd_get (_LIBC_TSD_KEY_DL_ERROR) \ - : catch) -#else -# define tsd_setspecific(data) \ - if (__libc_internal_tsd_set != NULL) \ - __libc_internal_tsd_set (_LIBC_TSD_KEY_DL_ERROR, data); \ - else \ - catch = (data) -# define tsd_getspecific() \ - (__libc_internal_tsd_set != NULL \ - ? (struct catch *) __libc_internal_tsd_get (_LIBC_TSD_KEY_DL_ERROR) \ - : catch) -#endif + memory. */ + +__libc_tsd_define (static, DL_ERROR) +#define tsd_getspecific() __libc_tsd_get (DL_ERROR) +#define tsd_setspecific(data) __libc_tsd_set (DL_ERROR, (data)) /* This points to a function which is called when an error is diff --git a/linuxthreads/ChangeLog b/linuxthreads/ChangeLog index 34486668bd..32b0159701 100644 --- a/linuxthreads/ChangeLog +++ b/linuxthreads/ChangeLog @@ -1,3 +1,25 @@ +1998-11-29 Roland McGrath <roland@baalperazim.frob.com> + + * sysdeps/pthread/bits/libc-tsd.h (__libc_tsd_define, __libc_tsd_get, + __libc_tsd_set): New macros for new interface. + * no-tsd.c: New file, provide uninitialized defns of + __libc_internal_tsd_get and __libc_internal_tsd_set. + * Makefile (routines): Add no-tsd. + +1998-10-12 Roland McGrath <roland@baalperazim.frob.com> + + * internals.h: Include <bits/libc-tsd.h>, not <bits/libc-lock.h>. + * sysdeps/pthread/bits/libc-lock.h (__libc_internal_tsd_get, + __libc_internal_tsd_set): Move decls to ... + * sysdeps/pthread/bits/libc-tsd.h: New file for __libc_internal_tsd_* + declarations. + + * sysdeps/pthread/bits/libc-lock.h (__libc_internal_tsd_get, + __libc_internal_tsd_set): Make these pointers to functions, not + functions; remove #pragma weak decls for them. + * specific.c (__libc_internal_tsd_get, __libc_internal_tsd_set): + Define static functions and initialized pointers to them. + 1998-11-18 Ulrich Drepper <drepper@cygnus.com> * Makefile (CFLAGS-mutex.c): Define as -D__NO_WEAK_PTHREAD_ALIASES. diff --git a/linuxthreads/Makefile b/linuxthreads/Makefile index aad7106f4c..c19145fc00 100644 --- a/linuxthreads/Makefile +++ b/linuxthreads/Makefile @@ -27,7 +27,7 @@ linuxthreads-version := $(shell sed -n 's/^.*$(subdir)-\([0-9.]*\).*$$/\1/p' \ headers := pthread.h semaphore.h bits/semaphore.h distribute := internals.h queue.h restart.h spinlock.h -routines := weaks +routines := weaks no-tsd extra-libs := libpthread extra-libs-others := $(extra-libs) diff --git a/linuxthreads/internals.h b/linuxthreads/internals.h index d11cf8471a..9765402dd1 100644 --- a/linuxthreads/internals.h +++ b/linuxthreads/internals.h @@ -16,7 +16,7 @@ /* |