diff options
| -rw-r--r-- | BUGS | 10 | ||||
| -rw-r--r-- | ChangeLog | 59 | ||||
| -rw-r--r-- | FAQ.in | 15 | ||||
| -rw-r--r-- | bits/fenv.h | 4 | ||||
| -rw-r--r-- | math/libm-test.c | 97 | ||||
| -rw-r--r-- | math/math.h | 6 | ||||
| -rw-r--r-- | math/test-fenv.c | 44 | ||||
| -rw-r--r-- | misc/fstab.c | 195 | ||||
| -rw-r--r-- | nis/ypclnt.c | 70 | ||||
| -rw-r--r-- | sysdeps/alpha/fpu/bits/fenv.h | 6 | ||||
| -rw-r--r-- | sysdeps/generic/bits/fenv.h | 4 | ||||
| -rw-r--r-- | sysdeps/i386/fpu/bits/fenv.h | 6 | ||||
| -rw-r--r-- | sysdeps/i386/fpu/bits/mathinline.h | 24 | ||||
| -rw-r--r-- | sysdeps/i386/fpu/fesetenv.c | 8 | ||||
| -rw-r--r-- | sysdeps/libm-ieee754/s_log2.c | 7 | ||||
| -rw-r--r-- | sysdeps/libm-ieee754/s_log2f.c | 7 | ||||
| -rw-r--r-- | sysdeps/m68k/fpu/bits/fenv.h | 6 | ||||
| -rw-r--r-- | sysdeps/powerpc/bits/fenv.h | 6 | ||||
| -rw-r--r-- | sysdeps/powerpc/test-arith.c | 4 | ||||
| -rw-r--r-- | sysdeps/sparc/sparc32/fpu/bits/fenv.h | 6 | ||||
| -rw-r--r-- | sysdeps/sparc/sparc64/fpu/bits/fenv.h | 6 |
21 files changed, 420 insertions, 170 deletions
@@ -1,7 +1,7 @@ List of known bugs (certainly very incomplete) ---------------------------------------------- -Time-stamp: <1998-02-20T15:02:41-0800 drepper> +Time-stamp: <1998-02-26T09:19:15-0800 drepper> This following list contains those bugs which I'm aware of. Please make sure that bugs you report are not listed here. If you can fix one @@ -27,8 +27,6 @@ Severity: [ *] to [***] [ **] There are problems with signal handling when using LinuxThreads. -[ **] The libm-ieee `log2' function seems to be very inaccurate. - [ *] The precision of the `sinhl' and/or `asinhl' function do not seem to be the best. @@ -56,7 +54,11 @@ Severity: [ *] to [***] category. [PR libc/207] -[ *] The libm-ieee `asin' function gives wrong results (at least for 0.5). +[ *] The libm-ieee `gamma' function gives wrong results (at least for + -0.5). + +[ *] The libm-ieee `scalb' function gives wrong results for + non-integral second parameters. [ *] _IO_getline can loop forever, at least with C++ [PR libc/332] @@ -1,3 +1,62 @@ +1998-02-26 Ulrich Drepper <drepper@cygnus.com> + + * nis/ypclnt.c (yp_master): Check result of strdup. + Patch by Thorsten Kukuk. + +1998-02-26 Thorsten Kukuk <kukuk@vt.uni-paderborn.de> + + * nis/ypclnt.c: Give clnt handle after error checking free, change + return codes to fix problems with rpc.nisd in YP mode on Ultra's. + +1998-02-26 09:00 Ulrich Drepper <drepper@cygnus.com> + + * misc/fstab.c: Partly rewritten to use dynamically allocated buffer. + Patch by Joe Keane <jgk@jgk.org>. + + * misc/fstab.h (struct fstab): Change fs_type member to be const. + * misc/fstab.c: Remove casts in fs_type assignments. + +1998-02-26 Andreas Jaeger <aj@arthur.rhein-neckar.de> + + * sysdeps/i386/fpu/bits/fenv.h: Correct typo. ISO C 9X defines + FE_TOWARDZERO and not FE_TOWARDSZERO. Reported by H.J. Lu. + * sysdeps/sparc/sparc64/fpu/bits/fenv.h: Likewise. + * sysdeps/sparc/sparc32/fpu/bits/fenv.h: Likewise. + * sysdeps/powerpc/bits/fenv.h: Likewise. + * sysdeps/m68k/fpu/bits/fenv.h: Likewise. + * sysdeps/generic/bits/fenv.h: Likewise. + * sysdeps/alpha/fpu/bits/fenv.h: Likewise. + * sysdeps/i386/fpu/fesetenv.c (fesetenv): Likewise. + * sysdeps/powerpc/test-arith.c (main): Likewise. + +1998-02-25 Ulrich Drepper <drepper@cygnus.com> + + * sysdeps/i386/fpu/bits/mathinline.h: Also fix i386 versions of + the comparison macros. + +1998-02-21 20:14 H.J. Lu <hjl@gnu.org> + + * sysdeps/libm-ieee754/s_log2.c (ln2): Added. + (__log2): Fixed return values. + * sysdeps/libm-ieee754/s_log2f.c: Likewise. + +1998-02-25 Ulrich Drepper <drepper@cygnus.com> + + * math/math.h (isunordered): Rename local variables to ensure + correct code. Reported by HJ Lu. + +1998-02-25 10:34 Ulrich Drepper <drepper@cygnus.com> + + * sysdpes/i386/fpu/bits/mathinline.h (isgreater, isgreaterequal, + isless, islessequal, islessgreater, isunordered): Fix syntax for + fucompip instruction. + (isless, islessequal): Fix logic. + +1998-02-21 Andreas Jaeger <aj@arthur.rhein-neckar.de> + + * math/libm-test.c (sqrt_test): Add test for sqrt(2). + (comparisons_test): New tests for comparison macros. + 1998-02-24 15:12 Ulrich Drepper <drepper@cygnus.com> * Makeconfig: Filter out frame-pointer effecting options when @@ -150,6 +150,17 @@ in configparms. Later versions of egcs may fix these problems. If you have some more measurements let me know. +?? What version of the Linux kernel headers should be used? + +{AJ,UD} The headers from the most recent Linux kernel should be used. +The headers used while compiling the GNU C library and the kernel +binary used when using the library do not need to match. The GNU C +library runs without problems on kernels that are older than the +kernel headers used. The other way round (compiling the GNU C library +with old kernel headers and running on a recent kernel) does not +necessarily work. For example you can't use new kernel features when +using old kernel headers for compiling the GNU C library. + ?? When I run `nm -u libc.so' on the produced library I still find unresolved symbols. Can this be ok? @@ -601,10 +612,10 @@ problem. ?? What do I need for C++ development? {HJ,AJ} You need either egcs 1.0.1 or gcc-2.8.0 with libstdc++ -2.8.0. libg++ 2.7.2 (and the Linux Versions 2.7.2.x) doesn't work very +2.8.0. libg++ 2.7.2 (and the Linux Versions 2.7.2.x) doesn't work very well with the GNU C library due to vtable thunks. If you're upgrading from glibc 2.0.x to 2.1 you have to recompile -libstc++ the library compiled for 2.0 is not compatible due to the new +libstc++ the library compiled for 2.0 is not compatible due to the new Large File Support (LFS) in version 2.1. ? Source and binary incompatibilities, and what to do about them diff --git a/bits/fenv.h b/bits/fenv.h index c42540fa61..7552677d84 100644 --- a/bits/fenv.h +++ b/bits/fenv.h @@ -1,4 +1,4 @@ -/* Copyright (C) 1997 Free Software Foundation, Inc. +/* Copyright (C) 1997, 1998 Free Software Foundation, Inc. This file is part of the GNU C Library. The GNU C Library is free software; you can redistribute it and/or @@ -36,7 +36,7 @@ FE_TONEAREST FE_DOWNWARD FE_UPWARD - FE_TOWARDSZERO + FE_TOWARDZERO We define no macro which signals no rounding mode is selectable. */ diff --git a/math/libm-test.c b/math/libm-test.c index 7093fdcf14..e51bfe3eb6 100644 --- a/math/libm-test.c +++ b/math/libm-test.c @@ -46,6 +46,7 @@ fabs, fdim, floor, fma, fmax, fmin, fmod, fpclassify, frexp, gamma, hypot, ilogb, isfinite, isinf, isnan, isnormal, + isless, islessequal, isgreater, isgreaterequal, islessgreater, isunordered, ldexp, lgamma, log, log10, log1p, log2, logb, modf, nearbyint, nextafter, pow, remainder, remquo, rint, lrint, llrint, @@ -60,7 +61,7 @@ conj, cproj, cimag, creal, drem, j0, j1, jn, y0, y1, yn, significand, - nan, comparison macros (isless,isgreater,...). + nan The routines using random variables are still under construction. I don't like it the way it's working now and will change it. @@ -361,7 +362,7 @@ check_equal (MATHTYPE computed, MATHTYPE supplied, MATHTYPE eps, MATHTYPE * diff ret_value = (*diff <= eps && (signbit (computed) == signbit (supplied) || eps != 0.0)); - /* Make sure the subtraction/comparsion have no influence on the exceptions. */ + /* Make sure the subtraction/comparison have no influence on the exceptions. */ feclearexcept (FE_ALL_EXCEPT); return ret_value; @@ -2458,6 +2459,7 @@ sqrt_test (void) x = random_value (0, 10000); check_ext ("sqrt (x*x) == x", FUNC(sqrt) (x*x), x, x); check ("sqrt (4) == 2", FUNC(sqrt) (4), 2); + check ("sqrt (2) == 1.14142...", FUNC(sqrt) (2), M_SQRT2l); check ("sqrt (0.25) == 0.5", FUNC(sqrt) (0.25), 0.5); check ("sqrt (6642.25) == 81.5", FUNC(sqrt) (6642.25), 81.5); check_eps ("sqrt (15239.903) == 123.45", FUNC(sqrt) (15239.903), 123.45, @@ -5530,6 +5532,95 @@ fma_test (void) } +/* + Tests for the comparison macros + */ +typedef enum {is_less, is_equal, is_greater, is_unordered} comp_result; + + +static void +comparison2_test (MATHTYPE x, MATHTYPE y, comp_result comp) +{ + char buf[255]; + int result; + int expected; + + expected = (comp == is_greater); + sprintf (buf, "isgreater (%" PRINTF_EXPR ", %" PRINTF_EXPR ") == %d", x, y, + expected); + result = (isgreater (x, y) == expected); + check_bool (buf, result); + + expected = (comp == is_greater || comp == is_equal); + sprintf (buf, "isgreaterequal (%" PRINTF_EXPR ", %" PRINTF_EXPR ") == %d", x, y, + expected); + result = (isgreaterequal (x, y) == expected); + check_bool (buf, result); + + expected = (comp == is_less); + sprintf (buf, "isless (%" PRINTF_EXPR ", %" PRINTF_EXPR ") == %d", x, y, + expected); + result = (isless (x, y) == expected); + check_bool (buf, result); + + expected = (comp == is_less || comp == is_equal); + sprintf (buf, "islessequal (%" PRINTF_EXPR ", %" PRINTF_EXPR ") == %d", x, y, + expected); + result = (islessequal (x, y) == expected); + check_bool (buf, result); + + expected = (comp == is_greater || comp == is_less); + sprintf (buf, "islessgreater (%" PRINTF_EXPR ", %" PRINTF_EXPR ") == %d", x, y, + expected); + result = (islessgreater (x, y) == expected); + check_bool (buf, result); + + expected = (comp == is_unordered); + sprintf (buf, "isunordered (%" PRINTF_EXPR ", %" PRINTF_EXPR ") == %d", x, y, + expected); + result = (isunordered (x, y) == expected); + check_bool (buf, result); + +} + + +static void +comparison1_test (MATHTYPE x, MATHTYPE y, comp_result comp) +{ + comp_result comp_swap; + switch (comp) + { + case is_less: + comp_swap = is_greater; + break; + case is_greater: + comp_swap = is_less; + break; + default: + comp_swap = comp; + break; + } + comparison2_test (x, y, comp); + comparison2_test (y, x, comp_swap); +} + + +static void +comparisons_test (void) +{ + comparison1_test (1, 2, is_less); + comparison1_test (-30, 30, is_less); + comparison1_test (42, 42, is_equal); + comparison1_test (1, plus_infty, is_less); + comparison1_test (35, minus_infty, is_greater); + comparison1_test (1, nan_value, is_unordered); + comparison1_test (nan_value, nan_value, is_unordered); + comparison1_test (plus_infty, nan_value, is_unordered); + comparison1_test (minus_infty, nan_value, is_unordered); + comparison1_test (plus_infty, minus_infty, is_greater); +} + + static void inverse_func_pair_test (const char *test_name, mathfunc f1, mathfunc inverse, @@ -5838,6 +5929,8 @@ main (int argc, char *argv[]) isnormal_test (); signbit_test (); + comparisons_test (); + /* trigonometric functions */ acos_test (); asin_test (); diff --git a/math/math.h b/math/math.h index 5103f2ef3c..6c2ef27811 100644 --- a/math/math.h +++ b/math/math.h @@ -354,10 +354,10 @@ extern int matherr __P ((struct exception *__exc)); /* Return nonzero value if arguments are unordered. */ # ifndef isunordered -# define isunordered(x, y) \ +# define isunordered(u, v) \ (__extension__ \ - ({ __typeof__(x) __x = (x); __typeof__(y) __y = (y); \ - fpclassify (__x) == FP_NAN || fpclassify (__y) == FP_NAN; })) + ({ __typeof__(u) __u = (u); __typeof__(v) __v = (v); \ + fpclassify (__u) == FP_NAN || fpclassify (__v) == FP_NAN; })) # endif #endif diff --git a/math/test-fenv.c b/math/test-fenv.c index ab09410690..3a5a7ed692 100644 --- a/math/test-fenv.c +++ b/math/test-fenv.c @@ -1,4 +1,4 @@ -/* Copyright (C) 1997 Free Software Foundation, Inc. +/* Copyright (C) 1997, 1998 Free Software Foundation, Inc. This file is part of the GNU C Library. Contributed by Andreas Jaeger <aj@arthur.rhein-neckar.de> and Ulrich Drepper <drepper@cygnus.com>, 1997. @@ -117,28 +117,29 @@ static void print_rounding (int rounding) { - switch (rounding) { + switch (rounding) + { #ifdef FE_TONEAREST - case FE_TONEAREST: - printf ("TONEAREST"); - break; + case FE_TONEAREST: + printf ("TONEAREST"); + break; #endif #ifdef FE_UPWARD - case FE_UPWARD: - printf ("UPWARD"); - break; + case FE_UPWARD: + printf ("UPWARD"); + break; #endif #ifdef FE_DOWNWARD - case FE_DOWNWARD: - printf ("DOWNWARD"); - break; + case FE_DOWNWARD: + printf ("DOWNWARD"); + break; #endif #ifdef FE_TOWARDZERO - case FE_TOWARDZERO: - printf ("TOWARDZERO"); - break; + case FE_TOWARDZERO: + printf ("TOWARDZERO"); + break; #endif - } + } printf (".\n"); } @@ -154,11 +155,12 @@ test_rounding (const char *test_name, int rounding_mode) printf (" Pass: Rounding mode is "); print_rounding (curr_rounding); } - else { - ++count_errors; - printf (" Fail: Rounding mode is "); - print_rounding (curr_rounding); - } + else + { + ++count_errors; + printf (" Fail: Rounding mode is "); + print_rounding (curr_rounding); + } } @@ -247,7 +249,7 @@ feenv_nomask_test (const char *flag_name, int fe_exc) printf ("Test: after fesetenv (FE_NOMASK_ENV) processes will abort\n"); printf (" when feraiseexcept (%s) is called.\n", flag_name); - pid = fork (); + pid = fork (); if (pid == 0) { #ifdef RLIMIT_CORE diff --git a/misc/fstab.c b/misc/fstab.c index 8b87a1f1f0..d241051ec9 100644 --- a/misc/fstab.c +++ b/misc/fstab.c @@ -1,4 +1,4 @@ -/* Copyright (C) 1995, 1996, 1997 Free Software Foundation, Inc. +/* Copyright (C) 1995, 1996, 1997, 1998 Free Software Foundation, Inc. This file is part of the GNU C Library. The GNU C Library is free software; you can redistribute it and/or @@ -19,98 +19,175 @@ #include <fstab.h> #include <mntent.h> #include <stdio.h> +#include <stdlib.h> +#include <bits/libc-lock.h> -static FILE *fstab; -static struct mntent mntres; -static char buffer[8192]; +#define BUFFER_SIZE 0x1fc0 - -static FILE * -fstab_stream (void) +struct fstab_state { - if (! fstab) - fstab = setmntent (_PATH_FSTAB, "r"); - return fstab; -} + FILE *fs_fp; + char *fs_buffer; + struct mntent fs_mntres; + struct fstab fs_ret; +}; + +static struct fstab_state *fstab_init (int opt_rewind); +static struct mntent *fstab_fetch (struct fstab_state *state); +static struct fstab *fstab_convert (struct fstab_state *state); + +static struct fstab_state fstab_state; + int setfsent (void) { - if (fstab) - { - rewind (fstab); - return 1; - } - else - fstab = setmntent (_PATH_FSTAB, "r"); - return fstab ? 0 : 1; + return fstab_init (1) != NULL; } -static struct fstab * -internal_function -mnt2fs (struct mntent *m) -{ - static struct fstab f; - - if (m == NULL) - return NULL; - - f.fs_spec = m->mnt_fsname; - f.fs_file = m->mnt_dir; - f.fs_vfstype = m->mnt_type; - f.fs_mntops = m->mnt_opts; - f.fs_type = (hasmntopt (m, FSTAB_RW) ? (char *) FSTAB_RW : - hasmntopt (m, FSTAB_RQ) ? (char *) FSTAB_RQ : - hasmntopt (m, FSTAB_RO) ? (char *) FSTAB_RO : - hasmntopt (m, FSTAB_SW) ? (char *) FSTAB_SW : - hasmntopt (m, FSTAB_XX) ? (char *) FSTAB_XX : - (char *) "??"); - f.fs_freq = m->mnt_freq; - f.fs_passno = m->mnt_passno; - return &f; -} struct fstab * getfsent (void) { - FILE *s = fstab_stream (); + struct fstab_state *state; - if (! s) + state = fstab_init (0); + if (state == NULL) return NULL; - - return mnt2fs (__getmntent_r (s, &mntres, buffer, sizeof buffer)); + if (fstab_fetch (state) == NULL) + return NULL; + return fstab_convert (state); } + struct fstab * getfsspec (name) - register const char *name; + const char *name; { + struct fstab_state *state; struct mntent *m; - if (setfsent ()) - while (m = __getmntent_r (fstab, &mntres, buffer, sizeof buffer)) - if (!strcmp (m->mnt_fsname, name)) - return mnt2fs (m); + + state = fstab_init (1); + if (state == NULL) + return NULL; + while ((m = fstab_fetch (state)) != NULL) + if (strcmp (m->mnt_fsname, name) == 0) + return fstab_convert (state); return NULL; } + struct fstab * getfsfile (name) - register const char *name; + const char *name; { + struct fstab_state *state; struct mntent *m; - if (setfsent ()) - while (m = __getmntent_r (fstab, &mntres, buffer, sizeof buffer)) - if (!strcmp (m->mnt_dir, name)) - return mnt2fs (m); + + state = fstab_init (1); + if (state == NULL) + return NULL; + while ((m = fstab_fetch (state)) != NULL) + if (strcmp (m->mnt_dir, name) == 0) + return fstab_convert (state); return NULL; } + void endfsent () { - if (fstab) + struct fstab_state *state; + + state = &fstab_state; + if (state->fs_fp != NULL) { - (void) endmntent (fstab); - fstab = NULL; + (void) endmntent (state->fs_fp); + state->fs_fp = NULL; } } + + +static struct fstab_state * +fstab_init (int opt_rewind) +{ + struct fstab_state *state; + char *buffer; + FILE *fp; + + state = &fstab_state; + + buffer = state->fs_buffer; + if (buffer == NULL) + { + buffer = (char *) malloc (BUFFER_SIZE); + if (buffer == NULL) + return NULL; + state->fs_buffer = buffer; + } + + fp = state->fs_fp; + if (fp != NULL) + { + if (opt_rewind) + rewind (fp); + } + else + { + fp = setmntent (_PATH_FSTAB, "r"); + if (fp == NULL) + return NULL; + state->fs_fp = fp; + } + + return state; +} + + +static struct mntent * +fstab_fetch (struct fstab_state *state) +{ + return __getmntent_r (state->fs_fp, &state->fs_mntres, + state->fs_buffer, BUFFER_SIZE); +} + + +static struct fstab * +fstab_convert (struct fstab_state *state) +{ + struct mntent *m; + struct fstab *f; + + m = &state->fs_mntres; + f = &state->fs_ret; + + f->fs_spec = m->mnt_fsname; + f->fs_file = m->mnt_dir; + f->fs_vfstype = m->mnt_type; + f->fs_mntops = m->mnt_opts; + f->fs_type = (hasmntopt (m, FSTAB_RW) ? FSTAB_RW : + hasmntopt (m, FSTAB_RQ) ? FSTAB_RQ : + hasmntopt (m, FSTAB_RO) ? FSTAB_RO : + hasmntopt (m, FSTAB_SW) ? FSTAB_SW : + hasmntopt (m, FSTAB_XX) ? FSTAB_XX : + "??"); + f->fs_freq = m->mnt_freq; + f->fs_passno = m->mnt_passno; + return f; +} + + +/* Make sure the memory is freed if the programs ends while in + memory-debugging mode and something actually was allocated. */ +static void +__attribute__ ((unused)) |